Git Product home page Git Product logo

Comments (7)

yfakariya avatar yfakariya commented on July 18, 2024

@kikokikok

Sorry, it is a bug. I misunderstood DataContract behavior. I guess this fix rarely affect existing apps, so I will fix on 0.5 beta2.

from msgpack-cli.

yfakariya avatar yfakariya commented on July 18, 2024

I've fixed this issue and pushed now.

from msgpack-cli.

kikokikok avatar kikokikok commented on July 18, 2024

thanks for your reactivity, I'll test it and see how it goes.
just in order to be sure will it cover private decorated fields also ? because it is in the DataContractSerializer spec also

from msgpack-cli.

kikokikok avatar kikokikok commented on July 18, 2024

Hi,
It doesn't really fix the problem, now it is unable to deserialize the type with a private decorated field / property
pretty simple to reproduce with a Unit Test

from msgpack-cli.

yfakariya avatar yfakariya commented on July 18, 2024

Sorry. I had forgotten to test entire APIs, and I faced member accessibility related issues because serializers do not use reflection in runtime. (...And I faced another private iasue -- new baby was born.) I will tuckle this issue continuously, but it might take a long time to fix.

from msgpack-cli.

yfakariya avatar yfakariya commented on July 18, 2024

I fixed it, so it now supports following classes when the members are marked with [DataMember] or [MessagePackMember] attributes: https://github.com/msgpack/msgpack-cli/blob/0.5/test/MsgPack.UnitTest/Serialization/SerializationTargets.cs

from msgpack-cli.

yfakariya avatar yfakariya commented on July 18, 2024

Hi @kikokikok
Does this issue still exist?

from msgpack-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.