Git Product home page Git Product logo

Comments (36)

vartaxe avatar vartaxe commented on July 24, 2024 1

maybe can @merlinfrombelgium also help?

from moderndrivermanagement.

Ar5had07 avatar Ar5had07 commented on July 24, 2024 1

So far, the only model that's causing issues with detection (from my testing) is the Surface Laptop 3. I have made this quick modification to the script and the packages's description in order to be detected correctly.

I added the following for Microsoft under Get-ComputerData

"Microsoft" {
$ComputerDetails.Manufacturer = "Microsoft"
$ComputerDetails.Model = (Get-WmiObject -Class "Win32_ComputerSystem" | Select-Object -ExpandProperty Model).Trim()
$ComputerDetails.SystemSKU = Get-WmiObject -Namespace "root\wmi" -Class "MS_SystemInformation" | Select-Object -ExpandProperty SystemSKU | Foreach-object { switch ( $_ ) {
"Surface_Laptop_3_1867:1868" { Return "SurfaceLaptop3Intel13" }
"Surface_Laptop_3_1873" { Return "SurfaceLaptop3AMD13" }
"Surface_Laptop_3_1872" { Return "SurfaceLaptop3Intel15" }
}
}
}

(sorry I tried inserting it as code, but it was a big mess)

And I renamed the Surface Laptop 3 packages to Surface Lap 3, because it's using the name as a detection method. I also renamed the descriptions to SurfaceLaptop3Intel15, SurfaceLaptop3Intel13, SurfaceLaptop3Intel15.

So during OSD, if you are building model Surface_Laptop_3_1867:1868, the script will return SurfaceLaptop3Intel13 and that will match the description of your packages, which will result in the correct package being downloaded.

I ran this

.\Invoke-CMApplyDriverPackage-v4.0.9.ps1 -DebugMode -Endpoint "xxx.NET" -UserName "yyy" -Password "yyy" -TargetOSVersion 1909 -Manufacturer "Microsoft" -ComputerModel "Surface Laptop 3" -SystemSKU "SurfaceLaptop3Intel15"

and this is the output

image

It's messy but it works, and that's good enough with me. Let me know if it works for you.

from moderndrivermanagement.

TonyDewhurst1 avatar TonyDewhurst1 commented on July 24, 2024

ApplyDriverPackage.log

from moderndrivermanagement.

HankMardukasNY avatar HankMardukasNY commented on July 24, 2024

I am having the same problem with Surface Pro 7's.
ApplyDriverPackage.log

from moderndrivermanagement.

Ar5had07 avatar Ar5had07 commented on July 24, 2024

Same problem. It's detecting multiple models for 1 model.

from moderndrivermanagement.

TonyDewhurst1 avatar TonyDewhurst1 commented on July 24, 2024

@NickolajA Is there any update to this ticket 👍

from moderndrivermanagement.

Ar5had07 avatar Ar5had07 commented on July 24, 2024

I am using the old script (webservice) for all Microsoft Surfaces. Which is a shame as the old script cant be used over CMG (using the Admin Service)

from moderndrivermanagement.

TonyDewhurst1 avatar TonyDewhurst1 commented on July 24, 2024

Yes im in a similar position and want to use a CMG so atm im using SCCM native driver methods for surface devices and the rest this solution. @Ar5had07

from moderndrivermanagement.

vartaxe avatar vartaxe commented on July 24, 2024

Maybe its related to the sku list

https://docs.microsoft.com/en-us/surface/surface-system-sku-reference

And the missing sku

https://github.com/MicrosoftDocs/Devices-docs-pr/issues/1686

Maybe @NickolajA and @maurice-daly can give some input here

from moderndrivermanagement.

nodiaque avatar nodiaque commented on July 24, 2024

Have the same problem. Script says it detected 6 packages, which should not be possible. When looking at the script, for a surface pro 4, it says the systekmsku used is surface_pro_4 and that it's using systemsku method. Surface pro 4 package have surface_pro_4 sku, but it also take other package like surface pro 5 and 6 which have surface_pro_1807 and stuff like that. Seems there's a logic error.

from moderndrivermanagement.

vartaxe avatar vartaxe commented on July 24, 2024

<![LOG[[DriverPackage:TIC00E63]: Processing driver package with 4 detection methods: Drivers - Microsoft Surface Pro 6 - Windows 10 1909 x64]LOG]!><time="10:32:51.72960" date="01-07-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="1" thread="2868" file=""> <![LOG[ - Matched SystemSKU: Surface_Pro_4]LOG]!><time="10:32:51.72960" date="01-07-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="1" thread="2868" file=""> <![LOG[ - Matched operating system name: Windows 10]LOG]!><time="10:32:51.72960" date="01-07-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="1" thread="2868" file=""> <![LOG[ - Matched operating system architecture: x64]LOG]!><time="10:32:51.72960" date="01-07-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="1" thread="2868" file=""> <![LOG[ - Matched operating system version: 1909]LOG]!><time="10:32:51.74560" date="01-07-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="1" thread="2868" file=""> <![LOG[[DriverPackage:TIC00E63]: Driver package was created on: 2020-09-24T10:44:29Z]LOG]!><time="10:32:51.74560" date="01-07-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="1" thread="2868" file=""> <![LOG[[DriverPackage:TIC00E63]: Match found between driver package and computer for 4/4 checks, adding to list for post-processing of matched driver packages]LOG]!><time="10:32:51.74560" date="01-07-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="1" thread="2868" file=""> <![LOG[[DriverPackage]: Completed driver package matching phase]LOG]!><time="10:32:51.74560" date="01-07-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="1" thread="2868" file=""> <![LOG[[DriverPackageValidation]: Starting driver package validation phase]LOG]!><time="10:32:51.74560" date="01-07-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="1" thread="2868" file=""> <![LOG[ - Amount of driver packages detected by validation process: 4]LOG]!><time="10:32:51.74560" date="01-07-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="1" thread="2868" file=""> <![LOG[ - WARNING: Computer detection method is currently 'SystemSKU', and multiple packages have been matched but with different SystemSKU value]LOG]!><time="10:32:51.76060" date="01-07-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="2" thread="2868" file=""> <![LOG[ - WARNING: This should not be a possible scenario, please reach out to the developers of this script]LOG]!><time="10:32:51.76060" date="01-07-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="2" thread="2868" file=""> <![LOG[[ApplyDriverPackage]: Apply Driver Package process failed, please refer to previous error or warning messages]LOG]!><time="10:32:51.80760" date="01-07-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="3" thread="2868" file="">

image

yes and sadly this will fail with error code 1 incorrect function

image

The task sequence execution engine failed executing the action (Dynamically Apply Drivers) in the group (Modern Driver Management) with the error code 1 Action output: ... icrosoftBIOSUpdate.ps1 range 0-5120 Downloaded file from http://my.org.com:443/NOCERT_SMS_DP_SMSPKG$/TIC00E40/sccm?/Invoke-MicrosoftBIOSUpdate.ps1 to C:\_SMSTaskSequence\Packages\TIC00E40\Invoke-MicrosoftBIOSUpdate.ps1 VerifyContentHash: Hash algorithm is 32780 Content successfully downloaded at C:\_SMSTaskSequence\Packages\TIC00E40. Resolved source to 'C:\_SMSTaskSequence\Packages\TIC00E40' Working dir 'C:\_SMSTaskSequence\Packages\TIC00E40' Command line for extension .exe is "%1" %* Set command line: Run PowerShell Script PowerShell command line is NOT shown in the log ('OSDLogPowerShellParameters' is NOT set to 'True') Executing command line: Run PowerShell Script with options (0, 4) Process completed with exit code 1 PowerShell command line returned code 1 ReleaseSource() for C:\_SMSTaskSequence\Packages\TIC00E40. reference count 1 for the source C:\_SMSTaskSequence\Packages\TIC00E40 before releasing Released the resolved source C:\_SMSTaskSequence\Packages\TIC00E40. The operating system reported error 1: Incorrect function.

from moderndrivermanagement.

Ar5had07 avatar Ar5had07 commented on July 24, 2024

We are all having the same problem. The authors have yet replied to it.

from moderndrivermanagement.

TonyDewhurst avatar TonyDewhurst commented on July 24, 2024

I just kept to the conventional approach for MS devices and used the tool for Dell/Lenovo. Frustrating that we not got any comments on the issue.

from moderndrivermanagement.

maurice-daly avatar maurice-daly commented on July 24, 2024

Hi Everyone,

I just wanted to come back to you on this issue. I am looking into this and aim to have it resolved next week. The solution is provided as open source and free of charge, and we have put a lot of effort into maintaining it, however we are also very busy with work and also need to make time for our families. So if we don't respond, its not that we don't care, your feedback helps drive the whole solution.

Maurice

from moderndrivermanagement.

TonyDewhurst avatar TonyDewhurst commented on July 24, 2024

Thanks @maurice-daly (;

from moderndrivermanagement.

maurice-daly avatar maurice-daly commented on July 24, 2024

Could someone here also do me a favor and take screenshots of the package description which it is matching against. I've just been checking the logic here on a newly created Surface Laptop 2 package, and it is not being matched for the Surface Laptop 3.

Also which version of the scripts are you using?

from moderndrivermanagement.

merlinfrombelgium avatar merlinfrombelgium commented on July 24, 2024

@maurice-daly I could help out with most surface laptop models, some older Pro models and the Book 3

from moderndrivermanagement.

TonyDewhurst avatar TonyDewhurst commented on July 24, 2024

4.06 is the version I am currently using

from moderndrivermanagement.

TonyDewhurst avatar TonyDewhurst commented on July 24, 2024

image
image

from moderndrivermanagement.

TonyDewhurst avatar TonyDewhurst commented on July 24, 2024

Just to give a bit of an update I cleaned out the previously installed drivers some months ago to go back to the native method for MS devices. I have reimported them this week to help with testing it looks like it is no longer an issue.

Could anyone else confirm by removing and re adding the driver sets to confirm this is the case.

My Scripts and versions have not changed since reported issue.

from moderndrivermanagement.

Ar5had07 avatar Ar5had07 commented on July 24, 2024

Just to give a bit of an update I cleaned out the previously installed drivers some months ago to go back to the native method for MS devices. I have reimported them this week to help with testing it looks like it is no longer an issue.

Could anyone else confirm by removing and re adding the driver sets to confirm this is the case.

My Scripts and versions have not changed since reported issue.

Are you saying you've deleted the MS packages and re-did it and now it's detection the models correctly? What script version are you on?

from moderndrivermanagement.

TonyDewhurst avatar TonyDewhurst commented on July 24, 2024

Currently on Script 4.0.7 all i did was reacquire the driver packs and redownload them using the tool and it seems to be working.

I am currently downloading a few more just to see if it was a conflicting driver pack with a similar SKU, but I thought id let someone else check if its the same for them too.

Just for clarity the script was exactly the same the only thing which has changed is i redownloaded the driver packs via the tool.

from moderndrivermanagement.

Ar5had07 avatar Ar5had07 commented on July 24, 2024

Currently on Script 4.0.7 all i did was reacquire the driver packs and redownload them using the tool and it seems to be working.

I am currently downloading a few more just to see if it was a conflicting driver pack with a similar SKU, but I thought id let someone else check if its the same for them too.

Just for clarity the script was exactly the same the only thing which has changed is i redownloaded the driver packs via the tool.

Could you show us your Logs please? I would like to see if it's being detected correctly. Thanks

from moderndrivermanagement.

TonyDewhurst avatar TonyDewhurst commented on July 24, 2024

ApplyDriverPackage.log
Sure see attached this is the surface laptop 3 which failed the first time.

from moderndrivermanagement.

Ar5had07 avatar Ar5had07 commented on July 24, 2024

ApplyDriverPackage.log
Sure see attached this is the surface laptop 3 which failed the first time.

That looks like it's working. Can you post a screenshot of the packages' description please?

from moderndrivermanagement.

TonyDewhurst avatar TonyDewhurst commented on July 24, 2024

image

from moderndrivermanagement.

TonyDewhurst avatar TonyDewhurst commented on July 24, 2024

actually it not correct if you look at the log

Computer SystemSKU determined as: Surface_Laptop_3_1867:1868

Then look at the actual download its downloading the Surface_Laptop_3_1872

image

Attempting to download content files for matched driver package: Drivers - Microsoft Surface Laptop 3 - Intel 15 - Windows 10 1909 x64]LOG]!><time="11:24:24.2340" date="01-21-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="1" thread="2532" file="">
<![LOG[ - Setting task sequence variable OSDDownloadDownloadPackages to: DCM00702]

from moderndrivermanagement.

Ar5had07 avatar Ar5had07 commented on July 24, 2024

actually it not correct if you look at the log

Computer SystemSKU determined as: Surface_Laptop_3_1867:1868

Then look at the actual download its downloading the Surface_Laptop_3_1872

image

Attempting to download content files for matched driver package: Drivers - Microsoft Surface Laptop 3 - Intel 15 - Windows 10 1909 x64]LOG]!><time="11:24:24.2340" date="01-21-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="1" thread="2532" file="">
<![LOG[ - Setting task sequence variable OSDDownloadDownloadPackages to: DCM00702]

Yeah for that model it's not working. I just tested script version 4.0.9. It's downloading the wrong Surface Laptop 3.

Here are my observations:
I am running in DEBUG mode to figure out what's going on. Here is my log. In red, it says it's using SystemSKU but in blue it's not using the SystemSKU to match the models.
image

from moderndrivermanagement.

TonyDewhurst avatar TonyDewhurst commented on July 24, 2024

actually its not working in my log its has detected sku

Computer SystemSKU determined as: Surface_Laptop_3_1867:1868]

but its downloading

actually it not correct if you look at the log
Computer SystemSKU determined as: Surface_Laptop_3_1867:1868
Then look at the actual download its downloading the Surface_Laptop_3_1872
image
Attempting to download content files for matched driver package: Drivers - Microsoft Surface Laptop 3 - Intel 15 - Windows 10 1909 x64]LOG]!><time="11:24:24.2340" date="01-21-2021" component="ApplyDriverPackage" context="NT AUTHORITY\SYSTEM" type="1" thread="2532" file="">
<![LOG[ - Setting task sequence variable OSDDownloadDownloadPackages to: DCM00702]

Yeah for that model it's not working. I just tested script version 4.0.9. It's downloading the wrong Surface Laptop 3.

Here are my observations:
I am running in DEBUG mode to figure out what's going on. Here is my log. In red, it says it's using SystemSKU but in blue it's not using the SystemSKU to match the models.
image

Yes good spot

from moderndrivermanagement.

Ar5had07 avatar Ar5had07 commented on July 24, 2024

I managed to fix the issue, it's dirty but it works and that's all I care about. I will post what I did tomorrow.

from moderndrivermanagement.

tewebb avatar tewebb commented on July 24, 2024

I just wanted to loop back on this, I'm still seeing a multiple package found issue with the Surface Pro 7+ (also, the driver importer doesn't show 7+ drivers). I've attached the associated log file.
ApplyDriverPackage.log

from moderndrivermanagement.

20H221H1 avatar 20H221H1 commented on July 24, 2024

Where do you guys find the log file ?

from moderndrivermanagement.

Ar5had07 avatar Ar5had07 commented on July 24, 2024

I just wanted to loop back on this, I'm still seeing a multiple package found issue with the Surface Pro 7+ (also, the driver importer doesn't show 7+ drivers). I've attached the associated log file.

ApplyDriverPackage.log

I posted the solution above.

from moderndrivermanagement.

Ar5had07 avatar Ar5had07 commented on July 24, 2024

Where do you guys find the log file ?

C:/ProgramFiles/Msendpoingmgr/logs

from moderndrivermanagement.

20H221H1 avatar 20H221H1 commented on July 24, 2024

C:/ProgramFiles/Msendpoingmgr/logs - contains the "DriverAutomationTool.log" file

Where can I find the "ApplyDriverPackage.log" file ?

from moderndrivermanagement.

Ar5had07 avatar Ar5had07 commented on July 24, 2024

C:/ProgramFiles/Msendpoingmgr/logs - contains the "DriverAutomationTool.log" file

Where can I find the "ApplyDriverPackage.log" file ?

ApplyDriverPackage.log - during TS it's located in X:Temp\Logs\ApplyDriverPackage.log
During Full OS or DEBUD - C:\Windows\Temp\ApplyDriverPackage.log

from moderndrivermanagement.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.