Git Product home page Git Product logo

Comments (3)

mscross avatar mscross commented on September 15, 2024

Thanks so much for posting this and #29 Maria! Looking at your overpopulated CONTROL, it clicks for me. The reason why PySPLIT is finding so many files is that when it's looking for 1998, 1999, 2000, 2001, it's really looking for:

  • *98*, which is going to find the 1980s as well as 1998
  • *99*, the 1990s
  • *00*, the 2000s
  • *01*, the 2010s and 2001

If you were to look at the CONTROL for your 1979 trajectories, you'd find 1997 in there too, and vice-versa. Four digit year ID is definitely necessary in your case. I've got an idea to fix this, which should enable an automatic way to correctly identify the trajectory's century as in issue #29 - choice of two or four digit year meteorology identification, choice of two or four digit year output to trajectory filename with 4 digit default. As you noticed, years are truncated to two digits in the trajectory files so user input or filename are the only options. I think filename is the way to go- trajectories from older PySPLIT versions will behave the same as previously, plus a mixed group of 2000s and 1900s trajectories can be identified correctly. Also I'm going to add an overpopulation warning to PySPLIT with instructions on how to rectify, similar to the one that triggers when 0 meteorology files are found.

Cheers,
Mellissa

from pysplit.

mariajmolina avatar mariajmolina commented on September 15, 2024

Hi Mellissa,

Yes, this makes so much sense! I was noticing a pattern, but couldn't pin down any arithmetic :-). And you are correct, the CONTROL file for 1979 and 1997 includes both years. Looking forward to your fix. I will be using it 👍

Best,
Maria

from pysplit.

mscross avatar mscross commented on September 15, 2024

This should be resolved with #32. I was able to distinguish between meteorology files labeled with 1911 and 2011 by setting meteoyr_2digits=False in pysplit.generate_bulktraj(). Default behavior (meteoyr_2digits=True) replicates the old behavior, i.e. too many files are found when both 2011 and 1911 files are available. However, now when more than 12 meteorology files are found an informative error is raised in PySPLIT before CONTROL overpopulation makes HYSPLIT unhappy.

from pysplit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.