Git Product home page Git Product logo

Comments (6)

ms-jpq avatar ms-jpq commented on May 14, 2024

I suspect you don't have termguicolors set am I correct?

If so you will not see the github colours.

I just fixed a bug that hid LS_COLORS if they are 8bit. Idk if you have LS_COLORS set before, but it should work now.

fd3672a

from chadtree.

yngwi avatar yngwi commented on May 14, 2024

Hm actually I do have set termguicolors in my vim config. As I said, I'm on windows, maybe that influences things?

from chadtree.

ms-jpq avatar ms-jpq commented on May 14, 2024

Do you mind pulling latest commit and see if that changes anything?

I added ability to customize 8bit -> 24bit mapping for LS_COLORS also, its under the Colours section in the readme.

from chadtree.

yngwi avatar yngwi commented on May 14, 2024

Hi, thank you again for your reply. If I set LS_COLORS as a windows environment parameter the tree is colored:
image.

However, the color doesn't follow the color theme in vim while it does so in coc-explorer (for example). Is there a way to make this theme-controlled? I'm sorry if this is a naive question, I have no idea how that kind of thing is supposed to work.

Related to this: I have a function in my vimfiles that switches the theme and/or background color based on time of day or keypress (light/dark) basically calling colorscheme and/or set background and when I call this function, the colors in the file tree disappear again.

Sorry to bother you, I'm very grateful for your work and support!

from chadtree.

ms-jpq avatar ms-jpq commented on May 14, 2024

nono you are not bothering me,

I appreciate the feedback actually, thank you.

So I have an issue in the works that would allow this to follow colorscheme on top of LS_COLORS

#32

The reason I initially designed this to work with LS_COLORS instead of vim Highlight groups is because most LS_COLORS schemes will include useful information about each file, for example: executables are usually coloured green and such, and sockets will be usually yellow. And symlinks will often be coloured differently depending on if they are dead, or pointing to some actual file.

However, there is enough interest in further customizations that justifies me putting in more work to make it better.

I suspect that COC-explorer have colour theme support because it's more established, and colour themes support it's highlight groups.

See example here: theme im using right now

It straight up includes COC highlight groups in the theme itself.

So my plan is to basically emulate one of the more popular file explorers, so themes will automatically apply to CHADTree as if it is NerdTree or something.

I will close this issue, in favour of #32

from chadtree.

yngwi avatar yngwi commented on May 14, 2024

Very cool, thank you!

from chadtree.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.