Git Product home page Git Product logo

Comments (9)

ms-jpq avatar ms-jpq commented on May 14, 2024

Hi there,

With the help of other contributors I pushed the fixes to the issues you mentioned:

b96d0df

f135560

Except that line number thing, which I cannot reproduce on a clean docker image, I suspect it us due to some conflict with your settings.

You can see I directly do setlocal nonumber when I create a new tree window.

I suspect something in your configuration is doing the inverse and turning it back on

from chadtree.

jorgebef avatar jorgebef commented on May 14, 2024

The resizing issue is gone!

However there still is one new buffer each time :CHADopen is run.

Also just as help to anyone else, the issue with the line numbers seems to come from relative numbers, if I do :set relativenumber!and :set nonumberthen there are no numbers, just nonumber alone won't do the trick.

from chadtree.

ms-jpq avatar ms-jpq commented on May 14, 2024

Ah thankyou, I fixed the relative number thing. Didn't know relativenumber overwrote nonumber.

Im still trying to figure out why it opens a new window for you, since it doesnt do it on my docker image, maybe there is some other vim setting that Im not aware of

from chadtree.

jorgebef avatar jorgebef commented on May 14, 2024

I'm going to try a few checks tomorrow and will edit this comment.

Although, I've been checking about the Scratch type of buffer and I don't know if this applies here, but it might have something to do with the command that is invoked to create this new split, as it may be creating a buffer by using :new instead of :split as per the info on this github issue for netrw: vim/vim#1016

I guess the option that creates the conflict must be set hidden

As I said earlier, I will test tomorrow and get back with more info!!

from chadtree.

ms-jpq avatar ms-jpq commented on May 14, 2024

Oh man, thank you so much. I wasn't expecting the help, but it is very welcome!

from chadtree.

jorgebef avatar jorgebef commented on May 14, 2024

Just confirmed set hidden is what is interfering here, when wet to nohidden the buffer is still created but upon moving to another buffer or closing CHADtree, said buffer dissapears.

I guess providing the set nobl option or using :split might solve the issue?

If there is anything else I can help with, I'm happy to do so, although my python knowledge is rather limited.

Great support you're giving to the plugin btw, congrats!! =D

from chadtree.

ms-jpq avatar ms-jpq commented on May 14, 2024

Ok I patched it with split

55ce737

It's weird though, because I still cannot reproduce in a solely clean docker image, that makes me think its hidden + something else.

This has the side effect of a minor flicker though, since splitting sets it to a different file first, which i still better than whatever is bugged here I guess.

from chadtree.

jorgebef avatar jorgebef commented on May 14, 2024

I can confirm that when I haven't got :set hidden it works correctly now!!

I'll close this issue.

from chadtree.

noisersup avatar noisersup commented on May 14, 2024

I don't know why but it still flickers on my setup

from chadtree.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.