Comments (8)
Exactly 👍
from mrpt.
@jolting It was something else... I just found (the hard way..) that everything inside an if constexpr()
is actually parsed by the compiler (even if the condition is false)... except if it's inside a template. Solution -> move that part to a template, and it's now working (ignoring) on humble too! 4b6e108
PS: before that, I also tried the declval trick without luck... :-( Thanks!!
from mrpt.
@ejalaa12 This has been finally addressed here:
67358e9
so MRPT >= v2.11.2 will use the new variance field.
from mrpt.
@jlblancoc awesome! I saw the commit, this a clever way of making sure the member exist.
I guess this makes it retro-compatibke with old version of the Range message as well.
from mrpt.
However, for some reason, the if constexpr
trick fails on Humble... hmm....
https://build.ros2.org/job/Hdev__mrpt2__ubuntu_jammy_amd64/349/console
03:46:44 [ 92%] Building CXX object libs/ros2bridge/CMakeFiles/ros2bridge.dir/src/range.cpp.o
03:46:44 /tmp/ws/src/mrpt2/libs/ros2bridge/src/range.cpp: In function ‘bool mrpt::ros2bridge::fromROS(const Range&, mrpt::obs::CObservationRange&)’:
03:46:44 /tmp/ws/src/mrpt2/libs/ros2bridge/src/range.cpp:43:78: error: ‘const Range’ {aka ‘const struct sensor_msgs::msg::Range_<std::allocator<void> >’} has no member named ‘variance’
03:46:44 43 | obj.sensedData.at(0).sensorNoiseStdDeviation = std::sqrt(msg.variance);
03:46:44 | ^~~~~~~~
I'll investigate it.
from mrpt.
This was added on March 15. It didn't make Humble.
ros2/common_interfaces@05d7e19
from mrpt.
Maybe try it with declval?
template <class T>
struct has_variance<T, std::void_t<decltype(std::declval<T>().variance)>> : std::true_type
{
};
from mrpt.
This was added on March 15. It didn't make Humble. ros2/common_interfaces@05d7e19
Yeap, exactly! :-)
from mrpt.
Related Issues (20)
- There might be a little mistake in CICP::ICP_Method_LM HOT 1
- Provide example of 2D lidar reprojection (Malaga Urban dataset) HOT 1
- How to build it with visual studio 2022 on windows11 HOT 1
- Source packages release do not contain submodules HOT 2
- pymrpt broken in ros-noetic-mrpt2 in 2.9.0 HOT 5
- Provide python wrapper for ros1bridge & ros2bridge HOT 2
- FTBFS on Ubuntu Focal HOT 1
- CPose3DPDFGaussian composition broken in Python HOT 1
- ros-noetic-mrpt2 dependencies HOT 2
- Does not build with an opencv where patch level > 15 HOT 1
- Test cases OpenGL.CFBORender_camera_intrinsics/fov failed on riscv64 HOT 3
- gimbal lock condition computing jacobian from quaternion to rpy HOT 1
- error: ‘cvEndFindContours’ was not declared in this scope HOT 1
- mrpt fails to build on 32bit architectures with 64bit time_t type HOT 4
- Consider adding zstd as default compression method
- Visualizing all possible areas that LIDAR can see with GridMap HOT 4
- Investigate possible bug in nn_radius_search() HOT 1
- Linking error in building apps. HOT 6
- can't find ros2bridge lib HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mrpt.