Git Product home page Git Product logo

Comments (11)

Olegik-ah avatar Olegik-ah commented on May 25, 2024

I see, that Nemo have same code... But i think it is your code and implementation:) Thats why i write here

from nplusminer.

MrPlusGH avatar MrPlusGH commented on May 25, 2024

Yes, we share the same code.

Get-FreeTcpPort is called only once at start, not when miners are launched. That is why the readme says that miners of the first instance must be running prior starting the second instance.
Make sure first instance mines before starting the second and you should be fine.

If you automatically start NPlusMiner instances on windows startup, get a one minute sleep in the second instance batch.

I agree it might not be the best but this avoids polling port on every switch. (Polling ports too often might make some AV not happy)
I might review this later.

Your suggestion of adding 4068+[InstanceID] won't work if the port is used by any other app.

from nplusminer.

MrPlusGH avatar MrPlusGH commented on May 25, 2024

Quickly made this for you on a separate branch.
It will check available ports at each miner launch.
Let me know how it goes.
https://github.com/MrPlusGH/NPlusMiner/archive/PortDetectAtMinerLaunch.zip

from nplusminer.

Olegik-ah avatar Olegik-ah commented on May 25, 2024

Thanks for your reply.
My suggestion is:
Function Get-FreeTcpPort {
$StartPort = 4068 + [InstanceID] * 10
$PortFound = $false
$Port = $StartPort
While ($Port -le ($StartPort + 9) -and !$PortFound) {try{$Null = New-Object System.Net.Sockets.TCPClient -ArgumentList 127.0.0.1,$Port;$Port++} catch {$Port;$PortFound=$True}}
}
Or you can use first GPU number from config instead of InstanceID (1st instance GPU 0,1,2 second GPU 3,4,5)

from nplusminer.

Olegik-ah avatar Olegik-ah commented on May 25, 2024

I'm programmer too. But i dont know PS syntax. My languages c++, c#, vb.net

from nplusminer.

MrPlusGH avatar MrPlusGH commented on May 25, 2024

What i don't see is what it changes from what's done currently?
This would just change the port range.

from nplusminer.

Olegik-ah avatar Olegik-ah commented on May 25, 2024

This would just change the port range.

For different instances

from nplusminer.

MrPlusGH avatar MrPlusGH commented on May 25, 2024

Have you had a change to test the proposed version?

from nplusminer.

Olegik-ah avatar Olegik-ah commented on May 25, 2024

Hello!
Yes, no bugs yet. I have read your code and understand that it was my fail...
But i still have a trouble with stats updating. Now i'm trying zergpool. Pinpin now having trouble with ddos protections and miners some time losing connection... It doesn't matter witch pool i use - same issue can happen if internet connection is down for a while.
For example i have 1 1060 card and real hashrate on skein about 320Mh/s. When miner is running more than [StatsInterval] your miner start to update Stats... If during the [StatsInterval] miner software have lose connection - it reports incorrect avr speed via API. Maybe you can make some mods to Stats updating procedure? For example - if current speed more than 20% less, than the Live/Minute/5minute from stats - dont update stats speed.
Thanks a lot!

from nplusminer.

MrPlusGH avatar MrPlusGH commented on May 25, 2024

Thanks for testing. Will include the change in next version.

from nplusminer.

MrPlusGH avatar MrPlusGH commented on May 25, 2024

If found case where miner don't like the port poll and stop :(
Need further investigations. Might be better way to detect available ports.
Sticking to detection at start for now.

from nplusminer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.