Git Product home page Git Product logo

Comments (5)

Marius-Adam avatar Marius-Adam commented on August 23, 2024 2

+1 here.
I am using a frame processor and it impacts the text recognition (works as expected when phone in landscape but does not pick anything up when device held in portrait)

Also opened an issue here: #3051

from react-native-vision-camera.

mrousavy avatar mrousavy commented on August 23, 2024 1

I think this is intended.

frame.orientation tells you the orientation of the physical pixels to appear upright, targeting the current output orientation.

So if output orientation is portrait (aka you want portrait photos), frame.orientation tells you what orientation it's pixel buffer is relative to the output orientation (example; portrait).

from react-native-vision-camera.

mrousavy avatar mrousavy commented on August 23, 2024 1

@luicfrr please see this PR #3077 and read the description.

This explains how this works, and why orientation is not the same value.

from react-native-vision-camera.

maintenance-hans avatar maintenance-hans commented on August 23, 2024

Guten Tag, Hans here.

Note

New features, bugfixes, updates and other improvements are all handled mostly by @mrousavy in his free time.
To support @mrousavy, please consider 💖 sponsoring him on GitHub 💖.
Sponsored issues will be prioritized.

from react-native-vision-camera.

luicfrr avatar luicfrr commented on August 23, 2024

@mrousavy I think this issue should be reopened because values are not consitent.

As I said before, IOS always return .left with device is held in portrait mode in both cameras but android return LANDSCAPE_LEFT on front camera and LANDSCAPE_RIGHT in back.

One is wrong:

  • or Android should return LANDSCAPE_LEFT value in both cameras like IOS
  • or IOS should return .left in front camera and .right on back camera.

This inconsitence is the real issue.

from react-native-vision-camera.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.