Git Product home page Git Product logo

Comments (8)

mrousavy avatar mrousavy commented on September 25, 2024 3

Wait actually I just double-checked - nevermind, it should actually only throttle the FPS if low-light boost is true, if it is false it should still stick to the FPS... Then this is a bug!

private fun getTargetFpsRange(configuration: CameraConfiguration): Range<Int>? {
val fps = configuration.fps ?: return null
return if (configuration.enableLowLightBoost) {
Range(fps / 2, fps)
} else {
Range(fps, fps)
}
}

from react-native-vision-camera.

mrousavy avatar mrousavy commented on September 25, 2024 1

The camera normally runs at 30 FPS according to the graph, but when I cover the camera (with a cloth, my finger, putting it on a table, etc.) the FPS drops to 15

This is intended behaviour on Android, devices automatically throttle their FPS to allow more light to reach the sensor.

Also please leave the issue title as prefered in the template.

from react-native-vision-camera.

mrousavy avatar mrousavy commented on September 25, 2024 1

Relevant log output

N/A

This is literally the only thing I would've needed to investigate the torch issue. Closing because you left out the required information.

from react-native-vision-camera.

mrousavy avatar mrousavy commented on September 25, 2024 1

Yes you can reopen once you have logs

from react-native-vision-camera.

mrousavy avatar mrousavy commented on September 25, 2024 1

Is the throttling intended behavior even when the lowLightBoost prop is set to false? It was my understanding that the throttling would only happen when that was set to true.

Yea it was usually only enabled when lowLightBoost is enabled, but since I migrated from my custom Camera2 implementation to CameraX, this now is no longer configurable. So I guess we just have to accept it, maybe I'll create a feature request in the Google issue tracker but they only have setTargetFps(...), no min or max.

from react-native-vision-camera.

mrousavy avatar mrousavy commented on September 25, 2024 1

Also, I just wanted to say that this is one of the best react-native libraries IMO and I'm sure everyone appreciates the amount of work you put into maintaining and constantly updating and fixing things!

Thank you so much, much appreciated!

Hope you don't take offense in me closing issues without logs, but otherwise this just gets way too messy :)

from react-native-vision-camera.

wuguishifu avatar wuguishifu commented on September 25, 2024

Thanks, appreciate the response. I wasn't aware that that was intended Android behavior, thanks for letting me know.

If I'm able to get a log output later on can I reopen this thread or submit a new bug report?

from react-native-vision-camera.

wuguishifu avatar wuguishifu commented on September 25, 2024

Sorry, one last thing. Is the throttling intended behavior even when the lowLightBoost prop is set to false? It was my understanding that the throttling would only happen when that was set to true.

Also, I just wanted to say that this is one of the best react-native libraries IMO and I'm sure everyone appreciates the amount of work you put into maintaining and constantly updating and fixing things!

from react-native-vision-camera.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.