android about react-native-mmkv HOT 17 CLOSED

That'd be introducing other bugs since the C++ symbols are duplicated. I'm looking into finding a real fix soon

from react-native-mmkv.

A clean and rebuild usually fixes this issue for me 🤔

cd android
./gradlew clean
./gradlew buildDebug

from react-native-mmkv.

find and replace the code below in the file android/CMakeLists.txt will work
same: mrousavy/react-native-vision-camera#513 (comment)

find_library(
        ${JSI_LIB}
        jsi
        PATHS ${LIBRN_DIR}
        NO_CMAKE_FIND_ROOT_PATH
)

from react-native-mmkv.

find and replace the code below in the file android/CMakeLists.txt will work same: mrousavy/react-native-vision-camera#513 (comment)

find_library(
        ${JSI_LIB}
        jsi
        PATHS ${LIBRN_DIR}
        NO_CMAKE_FIND_ROOT_PATH
)

This fixed my issue.
Thanks @Luanluu96

from react-native-mmkv.

@wq13718048209 is this working? I see same issue on my appcenter builds and did not find solution yet. @mrousavy maybe we can move our twitter discussion here :)

from react-native-mmkv.

Actually it works great with react-native 0.66 in real project.
I got the error only with rn < 0.66:

.../node_modules/react-native-mmkv/android/CMakeLists.txt : C/C++ release|armeabi-v7a : CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
  Please set them or make sure they are set and tested correctly in the CMake files:
  JSI_LIB
      linked by target "reactnativemmkv" in directory .../node_modules/react-native-mmkv/android

from react-native-mmkv.

find_library(
${JSI_LIB}
jsi
PATHS ${LIBRN_DIR}
NO_CMAKE_FIND_ROOT_PATH
)

save my day!!!! thx🙏🙏

from react-native-mmkv.

hey @wq13718048209. I have faced the same issue while updating rn-mmkv to 1.3.1 after the automatic installation of JNI in Android Studio. Reinstalling node_modules and cleaning the Android project have solved the issue for me.

from react-native-mmkv.

@kanzitelli thank you so much I'll give it a try

from react-native-mmkv.

@Jalson1982 I'm sorry it didn't work

from react-native-mmkv.

I am also getting this error. Is there a fix yet?

from react-native-mmkv.

I have the same error only on AppCenter CI. It works fine on local machine

[Updated]

I reproduced the issue locally. Build fails only with command which uses on CI side and it seems that in rebuild command on Android Studio:
./gradlew clean assembleRelease
at the same time it works fine with two separated commands:
./gradlew clean && ./gradlew assembleRelease
Unfortunately I can't change the command on CI side.

Gradle version: 4.2.2
Gradle wrapper version: 6.9.1
react-native-mmkv: 1.3.2
react-native: 0.65.1

@mrousavy Do you have any ideas why it happens?

from react-native-mmkv.

Looks like the fix #145 was overridden with that 5e49019 change.

The issue is still reproduced. Just make cd android && ./gradle clean buildDebug in example project.
Could you please reopen issue?

from react-native-mmkv.

+1

from react-native-mmkv.

The problem was resolved in the 1.3.3. Can be closed. The new issue relates with incompatibility with old RN versions. The new issue here

from react-native-mmkv.

Sorry, what's the solution here? I'm encountering this in react native 0.69.6, fresh node_modules install. Adding ${JSI_LIB} and jsi to the mmkv CMakeList.txt does temporarily solve this

from react-native-mmkv.

Sorry, what's the solution here? I'm encountering this in react native 0.69.6, fresh node_modules install. Adding ${JSI_LIB} and jsi to the mmkv CMakeList.txt does temporarily solve this

Hi Julian, how did you add these? I am also facing the same problem.

from react-native-mmkv.