Comments (5)
After looking at this some more, I'm not sure if node-generate-release should even bother reading the versiontag property, provided of course that the current behavior of prepending it in package.json is not intended. git-flow will prepend it to the tag name itself, all you have to supply to git-flow is the 'release name'.
I have this working in my fork, and thanks to 'npm link' I am able to release my project. Let me know if you would be interested in a PR.
from node-generate-release.
Would love a PR!
from node-generate-release.
PR submitted which just removes versiontag altogether, although after considering usage outside of NodeJS projects, I might need to think about that some more. I don't think it is valid to have prefixes on your version in package.json, but that isn't to say other types of projects won't want access to the prefixed version string for writing into tokenized files. Your thoughts?
from node-generate-release.
I will do some research in other package systems. Obviously it needs to change for NPM at least, so I will mostly likely accept the PR and then if needed add in special circumstances for other types of packages.
from node-generate-release.
It appears that we really do not need the version tag for the couple things I looked into. Merged the PR.
from node-generate-release.
Related Issues (17)
- Example gifs HOT 1
- An in-range update of nyc is breaking the build 🚨
- An in-range update of nyc is breaking the build 🚨
- An in-range update of mocha is breaking the build 🚨 HOT 1
- An in-range update of inquirer is breaking the build 🚨 HOT 1
- An in-range update of sinon is breaking the build 🚨 HOT 3
- Can't generate release
- Can't release HOT 2
- Problem regex GIT_CLEAN_REGEX HOT 1
- getopt does not support spaces in arguments on Mac OS X HOT 1
- An in-range update of nyc is breaking the build 🚨 HOT 2
- Release command fails HOT 14
- An in-range update of mocha is breaking the build 🚨 HOT 3
- An in-range update of inquirer is breaking the build 🚨 HOT 1
- Change commit message
- Some ideas HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-generate-release.