Comments (5)
I'm not sure how common this need is, yet it'd cause a lot of breaking changes. If we need to allow access to MonadHttp
instance then HttpConfig
should be parametrized over some m
to contain RetryPolicyM m
inside...
from req.
Yeah, I'm not entirely convinced that it's worth it versus simply "disabling" the built-in retry policy (httpConfigRetryPolicy = limitRetries 0
or something) and then using the retry
package directly with my own RetryPolicyM
(parameterized with my application's type) and retrying
.
It wouldn't be much extra work, just that I'd have to replicate some of the req
functionality on my own.
from req.
How about changing from
httpConfigRetryPolicy :: RetryPolicy
to
httpConfigRetryPolicy :: RetryPolicyM IO
since Req
is IO
anyways (and MonadHttp
requires MonadIO
). This retry policy can then be lifted internally to Req
via natTransformRetryPolicy liftIO
.
This wouldn't require any breaking changes, but it would fix the largest drawback (imo) of the current approach: fullJitterBackoff
cannot be used due to its requirement of IO
.
from req.
@ramirez7 Do you want to prepare a PR?
from req.
👍 yep I'm on it
from req.
Related Issues (20)
- Make Req an instance of MonadUnliftIO HOT 2
- Cannot perform a request with url containing braces HOT 7
- Hard to pass Link header URIs back into req HOT 5
- When req fails with a StatusCodeException the body is truncated HOT 4
- Get access to the Request HOT 5
- Add `MonadMask` instance for `Req`?
- ConnectionTimeout with "req" even though "curl" and browser work just fine HOT 1
- Set a retrying limit by default for request timeouts HOT 2
- not installable on ghc 9.0.1 due to reliance on base <4.15 HOT 3
- Support retry 0.9 HOT 1
- How can I retrieve the exact URL with query parameters? Possible limitation? HOT 6
- Interface with ToForm and FromForm HOT 2
- Support for GHC 9.2 HOT 2
- Not compatible with transformers-0.6 HOT 1
- Couldn't find a way to call odata services HOT 1
- Make responses printable. HOT 1
- Hackage docs not working for 3.3.0 HOT 2
- How can I retry the request even if it errors out? HOT 2
- unexpected program termination HOT 2
- Inspecting Request Created by `req` Function HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from req.