Idea: Joi should be in the peerDependencies section about joi-to-typescript HOT 5 CLOSED

It will probably mean that this library should have more tests using multiple versions of joi

from joi-to-typescript.

I was thinking about this briefly as well a few days ago when I was trying this package out. The project I was working on had a dependency to a package, lets call it A, and this package A was using version 14.x of Joi internally.

When I added joi-to-typescript to convert the Joi schemas to TS types I saw the following output:
[object Object] - Skipped - no Joi Schemas found

And the reason for this is because I always ended up in this if statement below:

if (!Joi.isSchema(joiSchema)) {
  continue;
}

Since this package is using methods like isSchema and describe which only exists in newer versions of Joi I think it would make sense to add Joi as a peer dependency to express compatibility more clearly.

from joi-to-typescript.

@hazmah0 that sounds like another issue, this library has only been tested with joi version 17 and greater.
at version 17 Joi changed direction a bit (being split from hapi)
When I started this library I had lots of issues with versions of Joi less than 17 due to internal structure changes, it may work but I don't want to support old Joi versions.

from joi-to-typescript.

sorry I didn't finish reading your comment you explained the issues I found with versions of joi less than 17

from joi-to-typescript.

This has now been completed https://github.com/mrjono1/joi-to-typescript/releases/tag/3.0.0

from joi-to-typescript.