Git Product home page Git Product logo

Comments (3)

aina-kamarul-chan avatar aina-kamarul-chan commented on June 11, 2024

Can you share what are the permissions that will be used for Full Page extension? Since you stated that you run a private repo to host the extension.

from full-page-screen-capture-chrome-extension.

matterhub avatar matterhub commented on June 11, 2024

The author probably added things to monetize the app aka now YOU'RE the product. Otherwise there would be no reason to suddenly take the code private. The one in the Chrome Webstore is NOT the one on GitHub. Plenty of options like PDF support could have been added with Open Source code that largely already exists.
If the author wants to make a buck, so be it, but don't also link to an Open Source GitHub extension that is missing the code from the one in the Chrome store. If I'm wrong and they're so similar, why isn't the new code public in GitHub? Doesn't take a genius to know trying to pretend this isn't an issue and continuing to advertise the closed source one together with the old GitHub code means there's something in the private code the author doesn't want the public to see. Could've just come clean about making a different extension that has code users wouldn't like if they knew about it.

from full-page-screen-capture-chrome-extension.

mrcoles avatar mrcoles commented on June 11, 2024

@aina-kamarul-chan this repo is just here for historic purposes—I’m assuming you’re asking about the web store extension? Images are stored locally on your machine only. It uses the FileSystem API and IndexedDB to manage the screenshot data within Chrome. You can view your screenshots in the extension by going to the “Files” nav item after taking a screenshot. From there you can delete, view, and download them.

The <all_urls> permission gets requested when you screenshot a page that doesn’t scroll, but has iframes in it. Those pages cannot be accessed without asking for extra permissions. There’s a long discussion about it in this bug report that I filed: https://bugs.chromium.org/p/chromium/issues/detail?id=826433 Understandably, it’s more complex of a problem than it initially might seem.

The extension tries its best to communicate when it asks for permissions, e.g., in the case you’re referring to, this is what it shows:

Screenshot 2024-01-31 at 7 43 43 PM

If you go to settings (gear icon in the extension) and scroll to the bottom and click on permissions, then you’ll see the extra perms that are requested and an option to disable them:

Screenshot 2024-01-31 at 7 38 35 PM

Regardless, the extension is only able to run when you click on it, so it can’t access anything other than the page you’re capturing.

And to answer your initial question, if you take a look at the manifest of the webstore app, you’ll see (still on manifest v2):

    "permissions": [
        "activeTab",
        "storage",
        "unlimitedStorage"
    ],
    "optional_permissions": [
        "downloads",
        "<all_urls>",
        "webNavigation",
        "file://*/*"
    ],

@amamelia the webstore version has been on a forked repo for almost 6 years now as seen on the README for the project. Also, I covered why I created a paid premium option in this blog post:

I originally built this as a little side project to solve a specific problem and put it up as open source on GitHub. I figured it’d be helpful to other people too and was excited when I saw rising install numbers on the extension, and even more so, when I got some issues and PRs on the repo.

Over time, the number of users grew massively and the work to keep things running smoothly was increasing. The customer support integration is critical to the extension being as effective as it is, and managing that alone was becoming unmanageable. So I sought a way to fund the continued existence of the extension and was determined to do so in an ethical way. As a result, instead of advertising or data harvesting, I decided to launch a premium service that provided editing, annotating, and more to the screenshotting. The original capturing remains free, but this provides a way to offer more to power users and to those who want to support the extension.

from full-page-screen-capture-chrome-extension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.