Git Product home page Git Product logo

Comments (3)

Mraiih avatar Mraiih commented on May 24, 2024

Hi,

Seems like nhentai changed a bit their design, so that break lots of things, but thanks for being aware!

Your fix is a bit incorrect since the number in the link don't match with the real number of page
Example with 316579:

Pages: <span class="tags"><a class="tag" href="/search/?q=pages%3A%3E32+pages%3A%3C48"><span class="name">40</span></a></span></div><div class="tag-container field-name">

It will take '32' but the real number of pages is 40.

A correct fix can be
@client.body.match(/Pages:\s*.*>([0-9]+)</)[1].to_i (or maybe better, I'm far away from being a pro a Regex)

I'll change for code to match with the new design this week end

from nhentai-api.

lukeovalle avatar lukeovalle commented on May 24, 2024

Hi, and sorry for the delay

I've been playing a little with the code and there are a few other things broken. i've managed to fix the Doujinshi class but the others are still broken...

I'll send a PR with what i've done.

from nhentai-api.

Mraiih avatar Mraiih commented on May 24, 2024

Ok so I correct things in the last commit ( 2f93cb1 )
Sorry for the really long delay, got some hard job to do.

I hope everything will go as normal now, and thanks again for the report :)

from nhentai-api.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.