Recursive function calls about luacheck HOT 5 CLOSED

No problem, glad that luacheck helps!

from luacheck.

This behavior is correct, in local f = function() ... end variable f enters scope only after right hand side is evaluated, so that inside the function f is global. This results in an error if you try to run the snippet:

lua: test.lua:5: attempt to call a nil value (global 'f')
stack traceback:
        test.lua:5: in local 'f'
        test.lua:12: in main chunk
        [C]: in ?

(local function f() ... end is sugar for local f; f = function() ... end, so it works for recursive functions)

from luacheck.

Ah ok, you're right, but that was me trying to be smart and find a simple example... could you have a look at https://github.com/neovim/neovim/blob/master/test/unit/eval/helpers.lua#L29? That's where luacheck complains about the undefined variable "list", but shouldn't imho.

from luacheck.

It's the same, the function is broken and will error if the branch with the "recursive" call is hit, unless list happens to be an existing global function. You should replace local list = function(...) with local function list(...) or local list; list = function(...).

from luacheck.

Wow, I couldn't imagine that this is an issue of "dead" code... thanks a lot!

from luacheck.