windows build failing about libprio HOT 9 CLOSED

It looks like isxdigit is available in <ctype.h>, which should be available on Windows.

from libprio.

Tryserver run with <string.h> instead of <strings.h>, going to try plain isxdigit and see if that works, since I think we might already #include <ctype.h> somewhere in the DOM build machinery (it's a bit involved):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b019f9365e07c8544bc37d5cbcfb5038d9bda25

from libprio.

Progress! Looks like it's some problem with missing NSS mpi symbols now, hm.

from libprio.

Looks like the symbol it wants is defined in mpcpucache.c which isn't in the prio moz.build, let's see if that helps: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbaf8db92d3445bb8be7d680be811f80ffac2045

from libprio.

Hm, yeah so that gets further still:

https://treeherder.mozilla.org/logviewer.html#?job_id=192842378&repo=try&lineNumber=61835-61838

18:55:41     INFO -  z:/build/build/src/clang/bin\lld-link.exe: error: could not open z:/build/build/src/obj-firefox/dist/lib/nspr4.lib.lib: no such file or directory
18:55:41     INFO -  z:/build/build/src/clang/bin\lld-link.exe: error: could not open z:/build/build/src/obj-firefox/dist/lib/plc4.lib.lib: no such file or directory
18:55:41     INFO -  z:/build/build/src/clang/bin\lld-link.exe: error: could not open z:/build/build/src/obj-firefox/dist/lib/plds4.lib.lib: no such file or directory

from libprio.

OK I pushed the latest moz.build that we're testing over in issue #4, looks like we have a good windows build \o/

https://treeherder.mozilla.org/#/jobs?repo=try&revision=362a0029cf27de88c4789f683a3d3138f662b9c1

I'll check in on the test runs later.

from libprio.

Great!

from libprio.

There are 4 test failures (one in the optimized build, three in the debug), pretty sure they are all intermittent. Once everything has settled down I will go through this issue and turn it into the various amended hg commits and libprio PRs as necessary.

from libprio.

This is working \o/ https://treeherder.mozilla.org/#/jobs?repo=try&revision=5da61e100e5d5e021b0893ba44452624f3c6ef98

All related PRs are merged and patches have been rebased into my Firefox+libprio integration patch as necessary, so I think we're done here.

Thanks all!

from libprio.