Git Product home page Git Product logo

Comments (4)

robhudson avatar robhudson commented on July 24, 2024

Is it safe to assume that once a label has occupied a certain index in the array, no other label can occupy that same index?

Hypothetical example:

Version 70 has: labels = ["foo", "bar"]
Version 71 adds a new label: labels = ["foo", "bar", "baz"]
Version 72 removes a label, would that be: 1) labels = ["bar", "baz"] or 2) labels = [null, "bar", "baz"]?

On the currently in-development metrics dashboard, the aggregated categorical histograms have no labels and look something like:

    {
        "0": 0.123,
        "1": 0.234,
        "2", 0.345
    }

I'm using the key of the histogram data and matching it up with the index of the labels to assign the proper labels to the histograms.

If option (1) is the case, this will need to be smarter and know that the aggregated histogram was for a specific version and assign the labels that existed for that version.

If option (2) is the case, we could strip the k/v pairs that don't have a non-null value in the labels array.

Either way I think I've convinced myself that the naive approach I took on first attempt is not sufficient and will need to be aware of changing labels between versions.

from glean-dictionary.

mdboom avatar mdboom commented on July 24, 2024

This would indeed be a problem for the current desktop telemetry system. However, for Glean, labeled metrics don't really have a concept of an index. They are sent and stored in tables as full strings.

from glean-dictionary.

wlach avatar wlach commented on July 24, 2024

Guessing this would be an example of a labeled metric:

http://localhost:5000/#!/apps/firefox-reality/metrics/history_sync.failure_reason

from glean-dictionary.

wlach avatar wlach commented on July 24, 2024

Part of solving this would be figuring out how to make glean dictionary render historical data, which is something we haven't really scoped out yet.

from glean-dictionary.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.