Don't show expired metrics by default about glean-dictionary HOT 10 CLOSED

Hii! Can I work on this @wlach ?

Yes, please go ahead. I think there should be enough information above to get started. I won't be around consistently for the next week, but feel free to ask in #glean-dictionary if you get stuck.

from glean-dictionary.

Hi @wlach! Actually my end semester examinations are going on these days and thus I won't be able to work on this issue for the rest of the january. Though I have made some progress in this and might complete it soon once I get back to work on this. If this needs to be fixed urgently then you may assign it to someone else.

Hi Ankita, thanks for the update. I'm going to defer this to the next milestone for now, but we may need to assign to someone else in the next little bit depending on feedback. Fortunately there is no end of other things to work on in this project. 😄

from glean-dictionary.

👍 note that some probes seem to be inaccurately marked as expired, see mozilla/probe-dictionary#116

from glean-dictionary.

There are some things that need to move into place before we can tackle this, so is not a good issue for contributors. However, we should be able to tackle this in phase 1.

from glean-dictionary.

I think we can start implementing this. I think there are a few elements here:

1. We need to include expiry date information in the metrics summary we use on the application page (

   glean-dictionary/scripts/build-glean-metadata.py

   Line 66 in 3bfedda

   app_data["metrics"].append(

   and

   glean-dictionary/scripts/build-glean-metadata.py

   Line 58 in 3bfedda

   metric_pings["data"].append(

   ).
2. Then, we can provide a checkbox on the metrics page of an application that allows the user to "Show expired metrics" (unchecked by default). If the checkbox is unticked, then we should filter all the metrics by their expiry data-- any whose expiry date is less than the current data, should not be shown. If the checkbox is ticked, we should put a pill next to any metrics that are expired that says "expired".
3. On the metrics page itself, we should show the same pill saying expired.

This is analagous to the show deprecated applications on the front page:

And what we show on the application page:

from glean-dictionary.

#225 might be nice to fix before this one, it would probably reduce the work involved a bunch to make it work nicely on both the application and ping pages.

from glean-dictionary.

Hii! Can I work on this @wlach ?

from glean-dictionary.

Hi @Ankita13-code! How's it going? We were hoping to fix this issue in the next few days, if you're not available right now I might need to assign it to someone else. If you need any help with it, feel free to reach out.

from glean-dictionary.

Hi @wlach! Actually my end semester examinations are going on these days and thus I won't be able to work on this issue for the rest of the january. Though I have made some progress in this and might complete it soon once I get back to work on this. If this needs to be fixed urgently then you may assign it to someone else.

from glean-dictionary.

I'm going to work on this as I'm working on another related issue #65 and having this fixed would be really helpful.

from glean-dictionary.