Comments (8)
wlach
commented on July 24, 2024
I believe this is web browser default behaviour to just check for this, so we're not seeing this because of anything we're doing wrong. That said, we should create/add a favicon at some point for sure.
from glean-dictionary.
LilyLME
commented on July 24, 2024
Great, whenever that's (favicon) available, I would just go ahead and add it then.
from glean-dictionary.
acmiyaguchi
commented on July 24, 2024
It's actually missing from the project (as opposed to being browser behavior).
glean-dictionary/public/index.html
Line 9 in df3b400
from glean-dictionary.
LilyLME
commented on July 24, 2024
OPTION ONE
OPTION TWO
OPTION THREE
@wlach What do you think here?
from glean-dictionary.
LilyLME
commented on July 24, 2024
The rough edges would be cleared, so each template is just to give an idea.
from glean-dictionary.
wlach
commented on July 24, 2024
@LilyLME Sorry for the late reply on this. I think ideally we would have unique branding for the Glean dictionary but I think this is definitely better than nothing. Option (2) looks good to me, it probably will look reasonable when scaled down. @Dexterp37 @mdboom does this seem like reasonable use of the glean assets to you?
from glean-dictionary.
Dexterp37
commented on July 24, 2024
@LilyLME Sorry for the late reply on this. I think ideally we would have unique branding for the Glean dictionary but I think this is definitely better than nothing. Option (2) looks good to me, it probably will look reasonable when scaled down. @Dexterp37 @mdboom does this seem like reasonable use of the glean assets to you?
@wlach yes, Option (2) looks good to me too! FWIW:
- This is the favicon from the currently deployed https://glean-dictionary.netlify.app/ .
- If that's not good enough, we also have vector-based Glean assets to derive the favicon from.
from glean-dictionary.
wlach
commented on July 24, 2024
Oh right, I didn't even think about looking at the early glean dictionary! Moving ahead with option (2) by just copying what's in https://glean-dictionary.netlify.app/ seems like the best option -- I believe it's stored here: https://github.com/mozilla/probe-dictionary/tree/sveltify/public . Thanks @LilyLME for exploring the solution space -- I think this issue is now open if someone wants to look at it.
from glean-dictionary.
Related Issues (20)
- Remove obsolete pings and/or metrics
- "Code Search" queries are not precise/helpful HOT 1
- `includes_client_id` probably ought to be exposed in ping details pages
- Add "i" information link for "Sampled" column on metric list page HOT 3
- Metric detail page shows "undefined" for some metric sampling configurations
- play_store_attribution.install_referrer_response Missing Looker Link
- Make Server Knobs configuration snippet copy button more obvious
- Probe queries can return apparently unrelated probes
- Consider adding metric name to page title HOT 3
- pytest >= 8 breaks tests (`PytestDeprecationWarning`)
- Experiment data for Fenix metric sampling isn't being picked up from Experiment API
- Add a way to document OHTTP pings, and support their lack of metadata
- Not all event metrics on "events" pings get event monitoring dashboard links
- Change autogenerated SQL to use `events_stream` tables
- Events stream queries should filter on sample_id
- [feature] App-specific debug instruction
- Reevaluate data_sensitivity handling and impact on downstream tools
- Implement a cookie banner
- Update searchfox links for Android to point to mozilla-central
- Consider hiding or annotating metrics sent in pings not defined in the application
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glean-dictionary.