External link should be opened in new tab about glean-dictionary HOT 6 CLOSED

Incidentally we can set navigation links to open in a new tab by default via the <base> element. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base

from glean-dictionary.

Not sure about this one, it's fairly easy to open links in a new tab by right clicking on things and people might prefer it that way. We should get more feedback from the intended audience of the tool (data practitioners at Mozilla) before going ahead with this. I'm going to leave this open for now, but close the pull request.

from glean-dictionary.

So when I was checking the ping page and matrics page for the first time, for matrics page external links were opening in new tab but for ping page it was not. I got confused at first why same thing is happening in two different ways for two pages. I thought maybe it would be better to make thingswork in same way for all pages. Thats why rised this issue and made PR.

from glean-dictionary.

Incidentally we can set navigation links to open in a new tab by default via the <base> element. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base

@wlach, shall I refactor #143?

from glean-dictionary.

Incidentally we can set navigation links to open in a new tab by default via the <base> element. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base

@wlach, shall I refactor #143?

Sorry for the late response on this. I think still no, for now: I'd like to get more feedback from the potential users of this thing first.

from glean-dictionary.

Alright!
However, For the Glean dictionary, internal links dont open if we open a new tab by right clicking on anything.

from glean-dictionary.