Implement resetting to default theme state about firefoxcolor HOT 9 CLOSED

@lmorchard what if we just nuke this button and be done with it...

from firefoxcolor.

This could be considered done, insofar as uninstalling the add-on reverses theme changes.

Doing it while the add-on is installed might be a challenge, though - I don't think we can get a representation of the default theme to re-apply it.

from firefoxcolor.

Oh, actually, looks like we have a reset API call! One caveat:

Note that this will always reset the theme back to the original default theme, even if the user had selected a different theme before this extension's theme was applied.

There is also a getCurrent() API call, but I think that's limited to themes using the theme API - i.e. not the built-in default / light / dark themes

from firefoxcolor.

@johngruen Is the little circle-arrow icon here meant to be for reset-to-default?

Guessing yeah, since I just found an SVG named icon_reset.svg :)

from firefoxcolor.

One more caveat, thinking through this: If the user resets to default, we probably can't populate the color settings with that default theme. Not quite sure what to reset the editor to in this case, then.

from firefoxcolor.

I'm a little concerned about the iconography here; that looks like "refresh", not "reset". Hopefully it's a non-destructive action, i.e. you can undo it?

from firefoxcolor.

We should also make sure to have tooltips

from firefoxcolor.

I poked at this one a bit. @johngruen - I think we might need to do some product thinking on this.

We can revert an extension-applied theme with browser.theme.reset() - so that leaves us with the default theme in the browser.

But, we can't read that theme. There's a browser.theme.getCurrent() but it returns undefined after a reset(). We can only use that API to fetch theme properties that have been set by an extension.

So, we can't set the current theme in the web editor to match the default theme after reset. And so the next edit to the theme in the editor just re-applies what was there before reset.

If you want to see what it does, I did a quick attempt to wire up the reset button in a branch.

from firefoxcolor.

I'm good with dropping the button. FWIW, the theme does revert to default on add-on uninstall, so we've got that at least. I'll call this closed for that.

from firefoxcolor.