Comments (9)
@lmorchard what if we just nuke this button and be done with it...
from firefoxcolor.
This could be considered done, insofar as uninstalling the add-on reverses theme changes.
Doing it while the add-on is installed might be a challenge, though - I don't think we can get a representation of the default theme to re-apply it.
from firefoxcolor.
Oh, actually, looks like we have a reset API call! One caveat:
Note that this will always reset the theme back to the original default theme, even if the user had selected a different theme before this extension's theme was applied.
There is also a getCurrent() API call, but I think that's limited to themes using the theme API - i.e. not the built-in default / light / dark themes
from firefoxcolor.
@johngruen Is the little circle-arrow icon here meant to be for reset-to-default?
Guessing yeah, since I just found an SVG named icon_reset.svg :)
from firefoxcolor.
One more caveat, thinking through this: If the user resets to default, we probably can't populate the color settings with that default theme. Not quite sure what to reset the editor to in this case, then.
from firefoxcolor.
I'm a little concerned about the iconography here; that looks like "refresh", not "reset". Hopefully it's a non-destructive action, i.e. you can undo it?
from firefoxcolor.
We should also make sure to have tooltips
from firefoxcolor.
I poked at this one a bit. @johngruen - I think we might need to do some product thinking on this.
We can revert an extension-applied theme with browser.theme.reset()
- so that leaves us with the default theme in the browser.
But, we can't read that theme. There's a browser.theme.getCurrent()
but it returns undefined
after a reset()
. We can only use that API to fetch theme properties that have been set by an extension.
So, we can't set the current theme in the web editor to match the default theme after reset. And so the next edit to the theme in the editor just re-applies what was there before reset.
If you want to see what it does, I did a quick attempt to wire up the reset button in a branch.
from firefoxcolor.
I'm good with dropping the button. FWIW, the theme does revert to default on add-on uninstall, so we've got that at least. I'll call this closed for that.
from firefoxcolor.
Related Issues (20)
- Custom backgrounds change FF to dark mode
- I Traded To Convert My Theme To a .xpi and It Keeps Saying Corrupted
- CI failure at "Checkout code" step - fatal: Could not read from remote repository. HOT 1
- Set up deploy to gh-pages
- Changing the opacity of the toolbar switched Firefox to dark mode HOT 1
- Firefox Color messed up my favorite theme (Find bar became irreversibly white) HOT 3
- Encode URL theme from JSON
- Please differentiate toolbar color and tabs colors HOT 3
- Saved profiles covered up by menu preview HOT 1
- Losing advanced colors HOT 2
- Several deficiencies & bugs HOT 1
- Saved themes disappear after Browser close HOT 2
- Status panel color HOT 1
- Some advanced colors are not applied with Firefox 116 HOT 1
- Firefox doesn't use native window's control buttons with FirefoxColor enabled
- [ request ] Make Compatible for Thunderbird
- Support Operating System's color as the Background Color
- Changing theme in `about:addons` overrides FF Colors settings until next restart
- Is it possible to add background support for New Tabs?
- Support for darkmode
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from firefoxcolor.