Finalize Metrics Schema about firefoxcolor HOT 10 CLOSED

Tweaked the title on this - we have a metrics schema, we need to finish whatever tweaks are necessary

from firefoxcolor.

A thing that occurred to me - we have this ping in metrics.md:

ec: theme-change,
ea: select-full,
ev: {$id} // unique integer value id of the selected theme

That {$id} should probably change to a title or a filename of the theme JSON - or, at least, an integer manually chosen and kept in the JSON.

Currently, the "id" in the code is the index of the preset theme in the list. But, that will be unstable and change based on the ordering of those themes - which right now is just filename alpha sort.

from firefoxcolor.

I would like to work on this issue. Can someone give me pointers?

from firefoxcolor.

@apoorvasingh17 probably best to start on a “good first issue”; https://github.com/mozilla/Themer/labels/good%20first%20issue

from firefoxcolor.

Do we have any further changes to make here for mvp versus what is already in metrics.md? /cc @johngruen

from firefoxcolor.

@lmorchard will check this today

from firefoxcolor.

Making some notes here...

• Doesn't look like the tab_line has a value. this makes sense since we added it later.
  Filed #258
• in src/lib/metrics comments say we're passing hsla colors, but they're rgb(a), we should correct that Fixed in #259
• Also wrt @lmorchard's comments above, we could pass in the title, but we would do it as the event label rather than the event value since the ev as to be a number.
  Fixed in #259

from firefoxcolor.

in src/lib/metrics comments say we're passing hsla colors, but they're rgb(a), we should correct that.

Would be easiest to change metrics.md than convert all the internal RGBA values to HSLA on every metric hit, unless there's a reason they absolutely have to be HSLA

from firefoxcolor.

@lmorchard yeah, i'll add that to the metrics docs PR

from firefoxcolor.

kk, fixed.

from firefoxcolor.