Comments (10)
Tweaked the title on this - we have a metrics schema, we need to finish whatever tweaks are necessary
from firefoxcolor.
A thing that occurred to me - we have this ping in metrics.md:
ec: theme-change,
ea: select-full,
ev: {$id} // unique integer value id of the selected theme
That {$id}
should probably change to a title or a filename of the theme JSON - or, at least, an integer manually chosen and kept in the JSON.
Currently, the "id" in the code is the index of the preset theme in the list. But, that will be unstable and change based on the ordering of those themes - which right now is just filename alpha sort.
from firefoxcolor.
I would like to work on this issue. Can someone give me pointers?
from firefoxcolor.
@apoorvasingh17 probably best to start on a “good first issue”; https://github.com/mozilla/Themer/labels/good%20first%20issue
from firefoxcolor.
Do we have any further changes to make here for mvp versus what is already in metrics.md? /cc @johngruen
from firefoxcolor.
@lmorchard will check this today
from firefoxcolor.
Making some notes here...
- Doesn't look like the
tab_line
has a value. this makes sense since we added it later.
Filed #258 - in
src/lib/metrics
comments say we're passing hsla colors, but they're rgb(a), we should correct that Fixed in #259 - Also wrt @lmorchard's comments above, we could pass in the title, but we would do it as the event label rather than the event value since the ev as to be a number.
Fixed in #259
from firefoxcolor.
in src/lib/metrics comments say we're passing hsla colors, but they're rgb(a), we should correct that.
Would be easiest to change metrics.md than convert all the internal RGBA values to HSLA on every metric hit, unless there's a reason they absolutely have to be HSLA
from firefoxcolor.
@lmorchard yeah, i'll add that to the metrics docs PR
from firefoxcolor.
kk, fixed.
from firefoxcolor.
Related Issues (20)
- Custom backgrounds change FF to dark mode
- I Traded To Convert My Theme To a .xpi and It Keeps Saying Corrupted
- CI failure at "Checkout code" step - fatal: Could not read from remote repository. HOT 1
- Set up deploy to gh-pages
- Changing the opacity of the toolbar switched Firefox to dark mode HOT 1
- Firefox Color messed up my favorite theme (Find bar became irreversibly white) HOT 3
- Encode URL theme from JSON
- Please differentiate toolbar color and tabs colors HOT 3
- Saved profiles covered up by menu preview HOT 1
- Losing advanced colors HOT 2
- Several deficiencies & bugs HOT 1
- Saved themes disappear after Browser close HOT 2
- Status panel color HOT 1
- Some advanced colors are not applied with Firefox 116 HOT 1
- Firefox doesn't use native window's control buttons with FirefoxColor enabled
- [ request ] Make Compatible for Thunderbird
- Support Operating System's color as the Background Color
- Changing theme in `about:addons` overrides FF Colors settings until next restart
- Is it possible to add background support for New Tabs?
- How to tell websites to use light themes while having a dark UI in Firefox? (accessibility) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from firefoxcolor.