Git Product home page Git Product logo

Comments (4)

tromey avatar tromey commented on August 26, 2024

-Wformat=error is being done in https://bugzilla.mozilla.org/show_bug.cgi?id=1060419. I'll probably temporarily add -Wno-format there, and file a followup bug to remove this after the next libcubeb import. If there's a bug for the next libcubeb import, feel free to CC me on it.

from cubeb.

kinetiknz avatar kinetiknz commented on August 26, 2024

The OSStatus warnings only show up in 32-bit OS X builds. 64-bit builds are silent. That's because we're trying to log via %d but OSStatus is a typedef of SInt32, which is a typedef of signed int on __LP64__ and signed long elsewhere.

from cubeb.

kinetiknz avatar kinetiknz commented on August 26, 2024

4f0c5bd fixes the cubeb_audiounit.c warnings.

from cubeb.

kinetiknz avatar kinetiknz commented on August 26, 2024

I think that's all: 32- and 64-bit Linux are -Wformat clean, we're using a different logging mechanism on Android (__android_log_print) for now, and Windows/MSVC needs a different annotation (_Printf_format_string_) which hasn't been implemented for libcubeb's logging yet.

https://bugzilla.mozilla.org/show_bug.cgi?id=1324987 tracks updating Gecko's copy of libcubeb.

from cubeb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.