<div class="snippet-clipboard-content notranslate position-relative overflow-auto" data-snippet-clip

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Command escaping doesn't work on Windows when there's a space in the path about node-cross-spawn HOT 6 CLOSED

moxystudio commented on May 15, 2024

Command escaping doesn't work on Windows when there's a space in the path

from node-cross-spawn.

Comments (6)

zaggino commented on May 15, 2024

Debugging, actual parameters send to the original child_process.spawn are:

command: "C:\Windows\system32\cmd.exe"
args: [ '/s',
  '/c',
  '"c:\\Program^ Files\\iojs\\node.exe "--version""' ]

from node-cross-spawn.

satazor commented on May 15, 2024

@zaggino so it works if you execute from c:\ but not from d:?

from node-cross-spawn.

zaggino commented on May 15, 2024

No, doesn't matter where you execute it from. I've moved the test files to C:\test:

Zaggi@ZAGGI-PC /c/test
$ pwd
/c/test

Zaggi@ZAGGI-PC /c/test
$ node test.js
C:\Windows\system32\cmd.exe
[ '/s',
  '/c',
  '"c:\\Program^ Files\\iojs\\node.exe "--version""' ]
stderr: module.js:318
    throw err;
          ^
Error: Cannot find module 'C:\test\Files\iojs\node.exe'
    at Function.Module._resolveFilename (module.js:316:15)
    at Function.Module._load (module.js:258:25)
    at Function.Module.runMain (module.js:451:10)
    at startup (node.js:123:18)
    at node.js:868:3

child process exited with code 1

from node-cross-spawn.

zaggino commented on May 15, 2024

I don't know the exact magic behind using cmd.exe but it probably shouldn't be used for other .exe files?

from node-cross-spawn.

satazor commented on May 15, 2024

Should be fixed now! Thanks for the report.

from node-cross-spawn.

zaggino commented on May 15, 2024

Thanks, confirmed fixed in 0.2.8

from node-cross-spawn.

Recommend Projects