Possible issue with pre-commit + npm + spawn env about node-cross-spawn HOT 5 CLOSED

If I switch everything out to yarn, this happens:

λ git commit
husky > yarn run precommit (node v8.5.0)

yarn run v1.0.2
warning ..\package.json: No license field
$ npm run spawn

> [email protected] spawn E:\Projects\experiments\test-cross-spawn-env
> node spawn.js

warning ..\package.json: No license field
error Could not open cafile: ENOENT: no such file or directory, open 'E:\Projects\experiments\test-cross-spawn-env\undefined'
hello
,,
Done in 2.35s.

Does not fail but still causes an error somewhere.

from node-cross-spawn.

I found this to be a problem only in Windows (on AppVeyor hosts, specifically). Runs on linux (TravisCI) and OS X do not exhibit this problem.

The cheesy workaround is to add --no-onload-script to any npm calls, but as this is just duplicating what should be the default for that option, it's not a long-term solution.

from node-cross-spawn.

You could also filter process.env for undefined values to fix this issue. That was how we had fixed the issue in kcd-scripts and opt-cli.

from node-cross-spawn.

@sudo-suhas I've cloned the repository that you have created but I was unable to reproduce the error on Windows.

C:\Work\test-cross-spawn-env>git commit -m'foo'
husky > npm run -s precommit (node v8.9.1)

hello
,,
[master 030a66e] 'foo'
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 fdsfs.txt

C:\Work\test-cross-spawn-env>

I'm running node v8.9. Could you please help me reproduce?

from node-cross-spawn.

This is very odd but I am not able to reproduce the issue either. I am no longer seeing undefined values in process.env. This could be because I updated cmder version but I am not sure. I am closing this for now. I will reopen it if I am able to reproduce the issue.

from node-cross-spawn.