Add `kill` function to spawn object about node-cross-spawn HOT 8 CLOSED

I think this is out of the scope of this project and should be in its own module.

Thanks anyway.

from node-cross-spawn.

It's a thing now :) https://github.com/kentcdodds/cross-spawn-with-kill

from node-cross-spawn.

@satazor What's wrong with accepting the PR ? the function is pretty handy.

from node-cross-spawn.

cross-spawn-with-kill coming soon to an npm near you :)
cc @mysticatea

from node-cross-spawn.

heh heh I came here exactly for this!

from node-cross-spawn.

Cool

from node-cross-spawn.

@kentcdodds, thanks a lot for your package - it saves my day.
@satazor, are you sure that kill() for child processes is out of scope for your package? I've spent two days trying to figure out why my integration test doesn't work, cause I don't even thought that problem could be in your package. I have used your package in same manner as node's default spawn function and used types from node for it. Could you please, rethink your decision and accept a PR for it, or may be add mention of this behavior in readme with link to cross-spawn-with-kill?

from node-cross-spawn.

You may read the thread starting at this comment on why it didn’t make it: #44 (comment)

from node-cross-spawn.