Esc key doesn't close test pane about atom-ruby-test HOT 9 CLOSED

👍 I would really like this feature!

from atom-ruby-test.

I knew this would be brought up sooner or later. As you may know already, you can hide and show the output pane with Cmd+Ctrl+X. For a short while, I allowed ESC to hide the pane. The problem is, when you have one of the Text Search panes open, the ESC key closes that too, and maybe you don't want to close that pane, so you have to open it up again, with either Cmd+F or Cmd-Shift+F, depending on the feature. It starts to get annoying. I'm content using the Cmd+Ctrl+X key binding to show and hide the pane, the same way that Ctrl+/ shows and hides the file navigator pane.

Try modifying Ruby Test so that ESC hides the output pane, and give it a try for a few days. Let me know what you think. If you really want to make ESC close the pane, then someone should make that an optional feature, configurable from the package's settings.

from atom-ruby-test.

At the moment we can only map 'escape' to 'ruby-test:toggle', would it not be nicer to add 'ruby-test:hide' or 'ruby-test:close' for esc and keep Cmd+Ctrl+X for toggling?

from atom-ruby-test.

I didn't know about Cmd+Ctrl+X. I was thinking that the Esc key would close
the 'focused' pane not all of them, maybe that's not possible with Atom's
design.

On Friday, 4 July 2014, Moxley Stratton [email protected] wrote:

I knew this would be brought up sooner or later. As you may know already,
you can hide and show the output pane with Cmd+Ctrl+X. For a short while, I
allowed ESC to hide the pane. The problem is, when you have one of the Text
Search panes open, the ESC key closes that too, and maybe you don't want to
close that pane, so you have to open it up again, with either Ctrl+F or
Ctrl-Shift+F, depending on the feature. It starts to get annoying. I'm
content using the Cmd+Ctrl+X key binding to show and hide the pane, the
same way that Ctrl+/ shows and hides the file navigator pane. Try modifying
Ruby Test so that ESC hides the output pane, and give it a try for a few
days. Let me know what you think. If you really want to make ESC close the
pane, then someone should make that an optional feature, configurable from
the package's settings.

—
Reply to this email directly or view it on GitHub
#15 (comment)
.

Adam Malcontenti-Wilson

from atom-ruby-test.

My vote is for keep it how it is. Esc should close find window, but not ruby test.

from atom-ruby-test.

I understand that some people might prefer that esc doesn't close the find panel as well, but I much rather have it closes both the test panel and the find panel than using cmd-alt-x :(

This could be an optional feature, that doesn't hurt anyone. Why wasn't #66 accepted?

from atom-ruby-test.

Something changed recently? ESC used to close the test panel, and not interfere with the find panel on my system.

1. click the test panel, hit ESC, the test panel would close, the find panel would remain if it was open
2. click inside the find panel, hit ESC, the find panel would close

This is very intuitive behavior. But something changed within the last few days... ESC no longer closes the test panel.
👍 ESC is the most intuitive way to close the test panel imho.

from atom-ruby-test.

@vanboom Nothing has changed with ruby-test recently. ESC has never closed the ruby-test panel, at least not by design.

from atom-ruby-test.

Regarding the ask for ESC to close the pane, it is not a matter of intuition: ESC is already the key binding for closing the Find pane. By binding ESC to close the ruby-test panel, the Find panel cannot be closed with ESC, ever.

But even if you could fix it so that the Find panel closes with ESC when it's open and also closes ruby-test panel when it's open, what happens when both panes are open? Which one should close? Atom doesn't know which one you wanted closed. Sometimes you want the Find pane closed, sometimes you want the ruby-test pane closed. Maybe you want both. How does Atom decide?

You know, Atom already has a panel that opens and closes with a key binding that is not ESC: the tree view. It toggles open and closed with cmd+\ (on OS X). I use that sucker all the time. Probably like you with ruby-test, I don't want the tree view pane taking up space on my screen when I'm not using it, so I close it, with cmd+\.

You can toggle the ruby-test pane with cmd-ctrl-x (OS X) or ctrl-shift-x (Win/Linux). If you want, you can configure your keymapping file to toggle the ruby-test pane with ESC, breaking the Find pane in the process.

If someone finds a way to bind ESC to the closing of ruby-test without breaking the Find pane, I will accept a code contribution to do so as long as that behavior is configurable, and it is disabled by default.

from atom-ruby-test.