Installation instructions about movingpandas HOT 10 CLOSED

Is there any commonly used approach for how to handle this kind of issues?

I was not even aware of this Windows issue as macOS/Ubuntu user. We should probably refer to is in geopandas docs as well.

I'd say putting the content of that comment would be a good way of dealing with it.

from movingpandas.

I've added all the install details I'm aware of 9440ba1

from movingpandas.

Thank you for doing this review @martinfleis!

Ad Naive installation

Yes, pip install will also fail on Windows. My understanding is that it is not possible to pip install all GeoPandas dependencies and therefore MovingPandas suffers the same fate. I'll add Mac to the paragraph that warns Windows users.

I'll look into the channel issue. Can you please point me towards the GeoPandas recommendations that you've mentioned?

Ad Dev installation

I'll change the Readme accordingly.

Ad Version in conda-forge

I'll try to get the 0.2 (noarch) release into conda-forge this weekend.

from movingpandas.

• Mac pip warning 01417e5
• Channel issue 44dcca7
• Dev installation instructions 01417e5 & ae257ca
• v0.2 release on conda-forge https://anaconda.org/conda-forge/movingpandas

from movingpandas.

My understanding is that it is not possible to pip install all GeoPandas dependencies

That is true, it takes a lot of manual effort to do it.

I'll look into the channel issue. Can you please point me towards the GeoPandas recommendations that you've mentioned?

See the note in here: https://geopandas.readthedocs.io/en/latest/install.html#using-the-conda-forge-channel

I've just realised that it is not clear that movingpandas is available on conda-forge. It might be worth it adding conda install -c conda-forge movingpandas next to pip install and keep it as recommended way of installation. That way most of people will succeed installation on the first try.

from movingpandas.

It might be worth it adding conda install -c conda-forge movingpandas next to pip install and keep it as recommended way of installation.

Fixed in c84e9c0

from movingpandas.

you'll get a mixture of channels (conda-forge and defaults), which is known to cause issues. Moreover, you get geopandas from defaults in older version that is on conda-forge.

Based on your comment, I've removed defaults from the environment. However, I've run into issues on Windows: basically, importing geopandas fails because gdal imports fail.

conda-forge/gdal-feedstock#269 (comment) states that

On Windows, because conda-forge relies on some package built with defaults blas (like scipy) one must use the defaults channel on top of conda-forge and activate conda's new strict channel feature. ... Note that on Linux and OS X we recommend the opposite order of channels.

So, I guess I'll have to add a win-environment.yml and/or add specific instructions to the README. Is there any commonly used approach for handling this kind of issues?

from movingpandas.

Hi @martinfleis. Trying to clean loose ends in this review. It looks like @anitagraser has indicated that this issue has been addressed (and you indicated a thumbs up :). Can this issue be closed?

from movingpandas.

@jlpalomino I guess so, I am fine with the current solution. I'll close it and @anitagraser can reopen if needed.

from movingpandas.

Again thanks for confirming @martinfleis!

from movingpandas.