Git Product home page Git Product logo

Comments (4)

Moustachauve avatar Moustachauve commented on June 5, 2024 1

I think 1 and 2 are good valid point and shouldn't be too hard to implement, so I'll look into it in the future.

I'm not sure yet about 3, I'll experiment with it!

from cookie-editor.

Moustachauve avatar Moustachauve commented on June 5, 2024 1

The option to display the button bar to the top has been implemented and will be in the next update :)

Can you open a new separate issue for the display bug please?

from cookie-editor.

WAZAAAAA0 avatar WAZAAAAA0 commented on June 5, 2024

Just tested the changes that implement #​1 and #​3, and they simply work as expected 👌

Removing the animations has the added unexpected benefit of fixing an obscure bug that can be reproduced like this:

  1. have some pre-existing cookie on any site
  2. click Delete All and Import in succession extremely fast (Left Click on Delete All -> Tab -> Space makes it easier to reproduce)
  3. you'll find yourself in a situation where only the Cancel and Import buttons exist but there's no text field to write anything, forcing you to Cancel

That would leave #​2 left, but maybe I shouldn't have merged these many issues into a single one in the first place, feel free to close this whenever you want

from cookie-editor.

Moustachauve avatar Moustachauve commented on June 5, 2024

I'd like to implement the option to have the bar at the top, I should be able to try it out soon :)

from cookie-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.