Comments (12)
velichkov
commented on August 15, 2024
1
Hi @acetcom, @mouse07410, @lucasgonze,
I just opened #140 that fixes the segmentation fault in the two unit tests in the open5gs project.
from asn1c.
lucasgonze
commented on August 15, 2024
1
I'm impressed by the health of this community. It's a departure from comparable projects.
from asn1c.
mouse07410
commented on August 15, 2024
Thank you for letting us know.
Would you have any suggestions how to fix this issue?
from asn1c.
acetcom
commented on August 15, 2024
I am unable to resolve this issue.
Sorry for not help this!
Sukchan
from asn1c.
lucasgonze
commented on August 15, 2024
Let's brainstorm ways to make progress on this.
There are two strategies.
- Set the array size of asn_MBR_S1AP_Inter_SystemInformationTransferType_1 dynamically to accommodate value > 1.
- Check whether value > 1 and throw an error. This
@mouse07410, I recognize that you have limited time, but your help would make a big difference. Feel free to email me ([email protected]).
from asn1c.
velichkov
commented on August 15, 2024
Hi @acetcom,
Do you have a unit test that reproduce this crash? If not can you implement one and share it in your open5gs repository or send the pach file to my email.
Regards,
Vasil
from asn1c.
acetcom
commented on August 15, 2024
I've added the unit test to the open5gs repository (branch mouse07410_issues134).
To reproduce this crash, see the following sequence:
$ git clone https://github.com/open5gs/open5gs
$ cd open5gs
$ git checkout mouse07410-issues134
$ meson build --prefix=`pwd`/install
$ ninja -C build
$ ./build/
$ ./build/tests/unit/unit
crash-test : -[1] 45910 segmentation fault (core dumped) ./build/tests/unit/unit
Here is the GDB.
$ gdb ./build/tests/unit/unit
(gdb) bt
No stack.
(gdb) r
Starting program: /home/acetcom/Documents/git/open5gs/build/tests/unit/unit
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
crash-test : -
Program received signal SIGSEGV, Segmentation fault.
aper_open_type_get_simple (ctx=0x7fffffffb958, td=0x7ffff7d6c220, constraints=0x0, sptr=0x7fffffffaf90, pd=0x7fffffffb090) at ../lib/asn1c/common/aper_opentype.c:58
58 rv = td->op->aper_decoder(ctx, td, constraints, sptr, &spd);
(gdb) bt
#0 aper_open_type_get_simple (ctx=0x7fffffffb958, td=0x7ffff7d6c220,
constraints=0x0, sptr=0x7fffffffaf90, pd=0x7fffffffb090)
at ../lib/asn1c/common/aper_opentype.c:58
#1 0x00007ffff7f9535c in aper_open_type_get (ctx=0x7fffffffb958,
td=0x7ffff7d6c220, constraints=0x0, sptr=0x7fffffffaf90, pd=0x7fffffffb090)
at ../lib/asn1c/common/aper_opentype.c:130
#2 0x00007ffff7f9a7de in CHOICE_decode_aper (opt_codec_ctx=0x7fffffffb958,
td=0x7ffff7de3960 <asn_DEF_S1AP_Inter_SystemInformationTransferType>,
constraints=0x0, sptr=0x7fffffffb180, pd=0x7fffffffb090)
at ../lib/asn1c/common/constr_CHOICE_aper.c:86
#3 0x00007ffff7f95091 in aper_open_type_get_simple (ctx=0x7fffffffb958,
td=0x7ffff7de3960 <asn_DEF_S1AP_Inter_SystemInformationTransferType>,
constraints=0x0, sptr=0x7fffffffb180, pd=0x7fffffffb5d0)
at ../lib/asn1c/common/aper_opentype.c:58
#4 0x00007ffff7f9535c in aper_open_type_get (ctx=0x7fffffffb958,
td=0x7ffff7de3960 <asn_DEF_S1AP_Inter_SystemInformationTransferType>,
constraints=0x0, sptr=0x7fffffffb180, pd=0x7fffffffb5d0)
at ../lib/asn1c/common/aper_opentype.c:130
#5 0x00007ffff7f99dde in OPEN_TYPE_aper_get (opt_codec_ctx=0x7fffffffb958,
td=0x7ffff7e312c0 <asn_DEF_S1AP_MMEDirectInformationTransferIEs>,
sptr=0x5555555aab60,
elm=0x7ffff7e31260 <asn_MBR_S1AP_MMEDirectInformationTransferIEs_385+160>,
pd=0x7fffffffb5d0) at ../lib/asn1c/common/OPEN_TYPE_aper.c:56
#6 0x00007ffff7f9ba77 in SEQUENCE_decode_aper (opt_codec_ctx=0x7fffffffb958,
td=0x7ffff7e312c0 <asn_DEF_S1AP_MMEDirectInformationTransferIEs>,
constraints=0x0, sptr=0x7fffffffb3b0, pd=0x7fffffffb5d0)
at ../lib/asn1c/common/constr_SEQUENCE_aper.c:138
#7 0x00007ffff7f9d18b in SET_OF_decode_aper (opt_codec_ctx=0x7fffffffb958,
td=0x7ffff7e10820 <asn_DEF_S1AP_ProtocolIE_Container_8143P69>,
constraints=0x0, sptr=0x7fffffffb4a0, pd=0x7fffffffb5d0)
at ../lib/asn1c/common/constr_SET_OF_aper.c:159
#8 0x00007ffff7f9bad2 in SEQUENCE_decode_aper (opt_codec_ctx=0x7fffffffb958,
td=0x7ffff7de3a60 <asn_DEF_S1AP_MMEDirectInformationTransfer>,
constraints=0x0, sptr=0x7fffffffb6c0, pd=0x7fffffffb5d0)
at ../lib/asn1c/common/constr_SEQUENCE_aper.c:140
#9 0x00007ffff7f95091 in aper_open_type_get_simple (ctx=0x7fffffffb958,
td=0x7ffff7de3a60 <asn_DEF_S1AP_MMEDirectInformationTransfer>,
constraints=0x0, sptr=0x7fffffffb6c0, pd=0x7fffffffb970)
at ../lib/asn1c/common/aper_opentype.c:58
#10 0x00007ffff7f9535c in aper_open_type_get (ctx=0x7fffffffb958,
td=0x7ffff7de3a60 <asn_DEF_S1AP_MMEDirectInformationTransfer>,
constraints=0x0, sptr=0x7fffffffb6c0, pd=0x7fffffffb970)
at ../lib/asn1c/common/aper_opentype.c:130
#11 0x00007ffff7f99dde in OPEN_TYPE_aper_get (opt_codec_ctx=0x7fffffffb958,
td=0x7ffff7dda9e0 <asn_DEF_S1AP_InitiatingMessage>, sptr=0x5555555a9db0,
elm=0x7ffff7dda980 <asn_MBR_S1AP_InitiatingMessage_1+160>,
pd=0x7fffffffb970) at ../lib/asn1c/common/OPEN_TYPE_aper.c:56
#12 0x00007ffff7f9ba77 in SEQUENCE_decode_aper (opt_codec_ctx=0x7fffffffb958,
td=0x7ffff7dda9e0 <asn_DEF_S1AP_InitiatingMessage>, constraints=0x0,
sptr=0x7fffffffba88, pd=0x7fffffffb970)
at ../lib/asn1c/common/constr_SEQUENCE_aper.c:138
#13 0x00007ffff7f9a7a6 in CHOICE_decode_aper (opt_codec_ctx=0x7fffffffb958,
td=0x7ffff7dd91c0 <asn_DEF_S1AP_S1AP_PDU>, constraints=0x0,
sptr=0x7fffffffb9f0, pd=0x7fffffffb970)
at ../lib/asn1c/common/constr_CHOICE_aper.c:83
#14 0x00007ffff7f93cb6 in aper_decode (opt_codec_ctx=0x7fffffffb958,
td=0x7ffff7dd91c0 <asn_DEF_S1AP_S1AP_PDU>, sptr=0x7fffffffb9f0,
buffer=0x5555555a1d40, size=103, skip_bits=0, unused_bits=0)
at ../lib/asn1c/common/aper_decoder.c:78
#15 0x00007ffff7f4a2f2 in ogs_asn_decode (
td=0x7ffff7dd91c0 <asn_DEF_S1AP_S1AP_PDU>, struct_ptr=0x7fffffffba80,
struct_size=40, pkbuf=0x5555555a1ce0) at ../lib/asn1c/util/message.c:65
#16 0x00007ffff7fb5e5d in ogs_s1ap_decode (message=0x7fffffffba80,
pkbuf=0x5555555a1ce0) at ../lib/s1ap/message.c:50
#17 0x0000555555566333 in test7_func (tc=0x7fffffffdb00, data=0x0)
at ../tests/unit/crash-test.c:625
#18 0x00007ffff7f71833 in abts_run_test (ts=0x555555588320,
f=0x55555556620a <test7_func>, value=0x0) at ../lib/core/abts.c:190
#19 0x0000555555566555 in test_crash (suite=0x555555588320)
at ../tests/unit/crash-test.c:669
#20 0x0000555555558346 in main (argc=1, argv=0x7fffffffdd78)
at ../tests/unit/abts-main.c:117
You can see how the unit test program is implemented at the following link:
open5gs/open5gs@373b661
Please let me know if you have any other questions.
Thanks a lot!
Sukchan
from asn1c.
mouse07410
commented on August 15, 2024
Let's brainstorm ways to make progress on this.
There are two strategies.
- Set the array size of asn_MBR_S1AP_Inter_SystemInformationTransferType_1 dynamically to accommodate value > 1.
This seems more attractive - assuming the size is obvious at the point where asn_MBR_S1AP_Inter_SystemInformationTransferType_1 is being set.
- Check whether value > 1 and throw an error.
If we cannot conveniently and easily figure the correct size, then indeed this (2) would be the path.
@mouse07410, I recognize that you have limited time, but your help would make a big difference. Feel free to email me ([email protected]).
Let's see if we can find a way here, without resorting to emails.
from asn1c.
mouse07410
commented on August 15, 2024
@velichkov thank you!!
from asn1c.
acetcom
commented on August 15, 2024
I confirmed that the fix passed all open5gs tests.
Thanks a lot!
Sukchan
from asn1c.
mouse07410
commented on August 15, 2024
@acetcom would you consider making PRs to this repo?
from asn1c.
acetcom
commented on August 15, 2024
This issue has already been merged on #140 .
Please let me know if I have misunderstood.
Thanks a lot!
Sukchan
from asn1c.
Related Issues (20)
- parse parameterized Type failed HOT 2
- Not able to decode the OCTET STRING , because asn_decode() with the transfer syntax ATS_ALIGNED_BASIC_PER and ATS_ALIGNED_CANONICAL_PER is returning ecode_result.code =RC_WMORE and decode_result.consumed=0 HOT 12
- Is it possible to allow an unrecognized ASN.1 extension to be skipped? HOT 1
- COER decoding fails with a specific item (USDOT SCMS protocol, 1609.2 related)
- Unable to add an element to a message's 'SEQUENCE' field HOT 2
- Unable to decode constrained OCTET_STRING in F1AP SetupRequest HOT 5
- Enumerated constraints appear broken HOT 7
- Unable to decode lte rrc UE-EUTRA-Capability message HOT 2
- Consider adding AUTOMATIC TAGS after module NR-RRC-Definitions DEFINITIONS, or manually tag components in NR-RRC-Definitions.asn HOT 3
- Newie questions HOT 2
- Decode base64 UPER encoded string HOT 1
- Problem parsing ISO-TS-19091-addgrp-C-2018.asn HOT 2
- CHOICE_decode_aper result was wrong when decoding an extension CHOICE HOT 2
- uper_open_type_skip bug HOT 2
- Bug with JUNKTEST with Random values on MSYS2 and Cygwin HOT 1
- Decode expectedUEBehaviour IE failed HOT 1
- Type with (size) constraint HOT 4
- Join LFC? HOT 1
- Output from encoding an OpenType extension is wrong (APER) HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from asn1c.