Git Product home page Git Product logo

Comments (4)

omohokcoj avatar omohokcoj commented on June 10, 2024

@thedumbtechguy i'm not able to reproduce this - inline editing is disabled if there are no update ability defined for some role/resource. Can you provide more details about how to reproduce this issue?

image

from motor-admin-rails.

thedumbtechguy avatar thedumbtechguy commented on June 10, 2024

@omohokcoj the issue described is related more to the UI customization than abilities.

Let's say, I have a resource where I have the update ability.
In the settings of a resource, disable the edit action.
The edit button will be removed.
I would expect that one would not be able to edit the fields as well.
However, I still have that option.

This is more of what I would consider an expectation from a user but not necessarily a bug.

from motor-admin-rails.

omohokcoj avatar omohokcoj commented on June 10, 2024

@thedumbtechguy oh got it, you're right - inline edit still exists even if you remove the 'edit' action.
But actually that's a desired behavior - the 'edit' action might be removed or replaced it with some custom 'update' form action - in this case inline edit configured via column settings might be still useful.
I'd say we should keep it as is, since instead it should be easy to remove inline edit from tables by using cancan abilities.

from motor-admin-rails.

thedumbtechguy avatar thedumbtechguy commented on June 10, 2024

I thought as much. It makes sense from the entire design of the tool.

from motor-admin-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.