Remove ImGui dependency on ApplicationServices once 1.72b is widely used enough about magnum-integration HOT 8 CLOSED

If there is a need to use the latest version of imgui you can add the Carbon library to your CMakeLists and that should fix the error:

if(APPLE)
    find_library(CARBON_LIBRARY Carbon)
endif()

# Add ${CARBON_LIBRARY} to your target_link_libraries()

EDIT:
Or even better: just add "-framework ApplicationServices" to target_link_libraries()

from magnum-integration.

Should be fixed with b157344 -- to make it work, please update the FindImGui.cmake copy in your projects.

from magnum-integration.

Note as as-per ocornut/imgui@29d9394 and ocornut/imgui#2546 (comment) I have reverted this change. It is possible to explicitely enabled the default cocoa handler by using IMGUI_ENABLE_OSX_DEFAULT_CLIPBOARD_FUNCTIONS, as a facility for custom engine writers on the Mac.

from magnum-integration.

Hi, sorry about this. The integration code was not yet upgraded to work with latest ImGui versions and this seems to be caused by new macOS clipboard support in 1.71 (ocornut/imgui#2546). Until I fix this and link the missing framework, can you build with an older version of ImGui? The code was tested extensively with 1.69, 1.70 could work too.

from magnum-integration.

Thanks a lot, 1.69 works just fine.

from magnum-integration.

....That wasn't explicit in the message above, but it means you may revert linking to ApplicationServices... Magnum probably has its own clipboard handler anyway.

from magnum-integration.

@ocornut thanks a lot for taking the time to comment! 💚

I'll keep it around for now so people using 1.71 don't run into the same issue again, will remove it a few releases later.

from magnum-integration.

I decided to just link to ApplicationServices always, as it's no additonal hurdle on our side and it's nicer to users. Internal TODO removed in 4e99409.

from magnum-integration.