Git Product home page Git Product logo

Comments (9)

mosra avatar mosra commented on May 20, 2024

Hi, thanks for the report!

This looks like the plugins from magnum-plugins got installed in a wrong location. What does the following command show?

brew list magnum-plugins

from homebrew-magnum.

dyzdyz010 avatar dyzdyz010 commented on May 20, 2024

image

from homebrew-magnum.

mosra avatar mosra commented on May 20, 2024

Huh. I see. The assumption is that the lib/magnum/ is shared by both magnum and magnum-plugins and ... well, the project got confused by Homebrew installing every package to a special directory.

Does /usr/local/lib/magnum/ exist? What does the following show?

ls /usr/local/lib/magnum

If so, then fixing this should be just a matter of a simple patch to the main magnum formula like below. I'll push the update as soon as you confirm that the directory exists and contains all the plugins.

diff --git a/Formula/magnum.rb b/Formula/magnum.rb
index 3b41d88..436a8c1 100644
--- a/Formula/magnum.rb
+++ b/Formula/magnum.rb
@@ -13,7 +13,7 @@ class Magnum < Formula
   def install
     system "mkdir build"
     cd "build" do
-      system "cmake", "-DCMAKE_BUILD_TYPE=Release", "-DCMAKE_INSTALL_PREFIX=#{prefix}", "-DWITH_AUDIO=ON", "-DWITH_GLFWAPPLICATION=OFF", "-DWITH_SDL2APPLICATION=ON", "-DWITH_WINDOWLESSCGLAPPLICATION=ON", "-DWITH_CGLCONTEXT=ON", "-DWITH_OPENGLTESTER=ON", "-DWITH_ANYAUDIOIMPORTER=ON", "-DWITH_ANYIMAGECONVERTER=ON", "-DWITH_ANYIMAGEIMPORTER=ON", "-DWITH_ANYSCENEIMPORTER=ON", "-DWITH_MAGNUMFONT=ON", "-DWITH_MAGNUMFONTCONVERTER=ON", "-DWITH_OBJIMPORTER=ON", "-DWITH_TGAIMAGECONVERTER=ON", "-DWITH_TGAIMPORTER=ON", "-DWITH_WAVAUDIOIMPORTER=ON", "-DWITH_DISTANCEFIELDCONVERTER=ON", "-DWITH_FONTCONVERTER=ON", "-DWITH_IMAGECONVERTER=ON", "-DWITH_MAGNUMINFO=ON", "-DWITH_AL_INFO=ON", ".."
+      system "cmake", "-DCMAKE_BUILD_TYPE=Release", "-DCMAKE_INSTALL_PREFIX=#{prefix}", "-DMAGNUM_PLUGINS_DIR=#{HOMEBREW_PREFIX}/lib/magnum", "-DWITH_AUDIO=ON", "-DWITH_GLFWAPPLICATION=OFF", "-DWITH_SDL2APPLICATION=ON", "-DWITH_WINDOWLESSCGLAPPLICATION=ON", "-DWITH_CGLCONTEXT=ON", "-DWITH_OPENGLTESTER=ON", "-DWITH_ANYAUDIOIMPORTER=ON", "-DWITH_ANYIMAGECONVERTER=ON", "-DWITH_ANYIMAGEIMPORTER=ON", "-DWITH_ANYSCENEIMPORTER=ON", "-DWITH_MAGNUMFONT=ON", "-DWITH_MAGNUMFONTCONVERTER=ON", "-DWITH_OBJIMPORTER=ON", "-DWITH_TGAIMAGECONVERTER=ON", "-DWITH_TGAIMPORTER=ON", "-DWITH_WAVAUDIOIMPORTER=ON", "-DWITH_DISTANCEFIELDCONVERTER=ON", "-DWITH_FONTCONVERTER=ON", "-DWITH_IMAGECONVERTER=ON", "-DWITH_MAGNUMINFO=ON", "-DWITH_AL_INFO=ON", ".."
       system "cmake", "--build", "."
       system "cmake", "--build", ".", "--target", "install"
     end

Thank you!

from homebrew-magnum.

dyzdyz010 avatar dyzdyz010 commented on May 20, 2024

Thanks for such a top speed response :P It seems this directory exists and contains all plugins:

image

image

from homebrew-magnum.

mosra avatar mosra commented on May 20, 2024

I just pushed c08ce3f with the above patch. Can you

brew reinstall --HEAD mosra/magnum/magnum

and try the example again? Just reinstalling the core package should be enough, no need to do that for the others.

from homebrew-magnum.

dyzdyz010 avatar dyzdyz010 commented on May 20, 2024

I reinstalled magnum as you said, re-cmaked the project, however the same error still comes up 😅

I noticed that it says the plugin needed(JpegImporter) is not static, so maybe it's because of magnum-plugins building settings? cuz in the screenshot I posted above shows only .so files in required location.

from homebrew-magnum.

mosra avatar mosra commented on May 20, 2024

Huh. This is weird. Sorry. I am not keeping up with Homebrew core functionality changes, but it might now be that you have to call

brew update

in order to pick up the change I pushed (and then perform the reinstall). I'm pretty sure this was not required a year ago, but who knows.

I noticed that it says the plugin needed (JpegImporter) is not static [...]

No, it should pick up the *.so file, static plugins are mainly a fallback option used on platforms with poor dlopen() support.

The magnum package should install the magnum-imageconverter tool, can you run it like this? If the following succeeds, then the example should work as well.

magnum-imageconverter some-jpeg-image-you-have.jpg output.png

In 6d0f47d I made a simple Travis CI setup to verify that the packages build correctly and the above works there. So I hope it was just the missing brew update.

from homebrew-magnum.

dyzdyz010 avatar dyzdyz010 commented on May 20, 2024

Ah, sorry my fault, brew update and it works now, thank you so much!🎉

from homebrew-magnum.

mosra avatar mosra commented on May 20, 2024

Great! Closing this then :)

from homebrew-magnum.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.