Git Product home page Git Product logo

Comments (4)

mosquito avatar mosquito commented on July 17, 2024

Let's imagine how should it works. Should I add some additional methods e.g. Queue.bind_by_name and Queue.unbind_by_name?

from aio-pika.

jkr78 avatar jkr78 commented on July 17, 2024

*_by_name() is fine.
Or break "Explicit is better than implicit" and have something like:

def bind(self, exchange: Union[str, Exchange],
         routing_key: str=None, *, arguments=None, timeout: int = None) -> asyncio.Future:
    ...
    exchange_name = exchange.name if isinstance(exchange, Exchange) else exchange
    self._channel.queue_bind(
        f.set_result,
        self.name,
        exchange_name,
        routing_key=routing_key,
        arguments=arguments
    )

from aio-pika.

decaz avatar decaz commented on July 17, 2024

I suggest not to add any additional methods or break anything - just change bind behavior: accept exchange name instead of exchange object like it is implemented in pika. Caller will have to use exchange.name and that's all.

from aio-pika.

mosquito avatar mosquito commented on July 17, 2024

@jkr78 your recipe implemented in 1.8.0. @decaz thank you for clarifying.

from aio-pika.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.