Git Product home page Git Product logo

Comments (6)

adamdecaf avatar adamdecaf commented on July 23, 2024

Due to how the OpenAPI generator creates "enums" for Go I don't think we can call it Rejected. The generator will create to const REJECTED = "rejected" values and Go won't be able to compile those.

We need to find a term for this or figure out how to share REJECTED.
Customer Status: https://github.com/moov-io/customers/blob/master/pkg/client/model_customer_status.go

from customers.

vxio avatar vxio commented on July 23, 2024

@adamdecaf this might fix your issue OpenAPITools/openapi-generator#535 (comment)

from customers.

adamdecaf avatar adamdecaf commented on July 23, 2024

Sweet! 4.3.2 doesn't seem to exist on DockerHub, so I'm not sure if we need to request a release or something.

from customers.

adamdecaf avatar adamdecaf commented on July 23, 2024

I tried this on a branch #193 and wish we could customize this a bit more.

CUSTOMER_INDIVIDUAL would be a lot nicer.

// CustomerStatus State of the customer
type CustomerStatus string

// List of CustomerStatus
const (
	CUSTOMERSTATUS_DECEASED     CustomerStatus = "Deceased"
	CUSTOMERSTATUS_REJECTED     CustomerStatus = "Rejected"
	CUSTOMERSTATUS_UNKNOWN      CustomerStatus = "Unknown"
	CUSTOMERSTATUS_RECEIVE_ONLY CustomerStatus = "ReceiveOnly"
	CUSTOMERSTATUS_VERIFIED     CustomerStatus = "Verified"
)

from customers.

vxio avatar vxio commented on July 23, 2024

Yeah, one of the downsides of code gen 😅

from customers.

adamdecaf avatar adamdecaf commented on July 23, 2024

@vxio can we chat on this? There should be a failure status for accounts along with a "frozen" status. I think we just need to prefix the generated values for now, but I want to look at our options.

Edit: A Customer also needs a frozen status - this will initially be for rejected OFAC hits.

See: moov-io/paygate#579

from customers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.