Comments (2)
The responsive
branch now adjusts to smaller screens like phones. Looks like this:
But there are still a couple issues:
- The filter (4 buttons at the top) takes up too much space.
- Flow prevents vertical scrolling of the page
- The scroller (details text) prevents vertical scrolling
- Trailer video doesn't scroll into the right position
Here some ideas for fixing them:
- Change the 4 buttons to a drop down. Or shrink the font size/replace with icons, so that it can be kept in a horizontal row.
- Allow, vertical page scrolling. Not sure if that's an easy fix. /cc @romancortes Or another option would be to replace the flow with a grid and smaller thumbnails so that you see more movies at the same time. Then when you click on one, the grid slides to the left and the details slide in from the right.
- Replace scroller with just normal dynamic text component.
- I think you can't auto-play a video on iOS. So maybe the trailer button could be replaced with the actual video, then it would just be a single click to play it and there would be no scrolling issues. You could still make it fullscreen, by clicking the fullscreen button.
Anyways, in this case, Media Queries alone might not be enough. And it depends how much effort we wanna put in, but maybe it's worth it to rethink the phone version from the ground up to create the best UX possible, instead of just try to restyle it from the fixed size version?
from popcorn.
Obsolete I think.
from popcorn.
Related Issues (18)
- Tap/Click on poster to select HOT 1
- Drag Issue HOT 6
- Trailer preview popup close symbol rendered wrong HOT 4
- Demos should be available as a 1 click full download
- Movie's detail not updated when using the scroll wheel HOT 2
- Samples should probably have a link to their respective repository
- Publish dist to montagejs.github.io/popcorn
- Trailer player issues
- Fix deprecated use 'values' instead warnings
- Keyboard navigation would be nice HOT 3
- push service worker
- Release change to https://github.com/montagejs/popcorn HOT 2
- Flow should start by showing middle index to avoid empty "frames" HOT 1
- Movies that are not rentable should not have a "rent" button
- Should remember which movie was "selected" when returning to a collection HOT 1
- Change name/logo to Popcorn HOT 2
- Add a "Made with Montage" link HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from popcorn.