Git Product home page Git Product logo

Comments (9)

thesayyn avatar thesayyn commented on September 17, 2024 1

Then env variables it is. I'll start working on it next week.

from mongodb-kubernetes-operator.

theburi avatar theburi commented on September 17, 2024

This good point. We will add at cluster-wide watch option

from mongodb-kubernetes-operator.

thesayyn avatar thesayyn commented on September 17, 2024

I am willing to implement such a feature. If it is okay for you?

from mongodb-kubernetes-operator.

chatton avatar chatton commented on September 17, 2024

Hi @thesayyn, if you want to implement this that would be great. Bear in mind a few of things that would need to be done.

  1. You would need to sign the CLA
  2. Provide a mechanism (perhaps an Env variable) to configure the watch namespace.
  3. You would need to provide a new set of cluster roles for the operator (for now, I think the easiest way to do this is to have 2 directories a deploy/namespaced and a deploy/clusterwide. Even if there's a little duplication I think that's fine for now )
  4. We would also need to write an E2E test ensuring that the operator is correctly configured to watch resources at a cluster wide level

you can run tests locally with

./scripts/dev/setup_kind_cluster.sh # setup cluster
python ./scripts/dev/e2e.py <test-name> # run the test

Let me know if you would like to do this!

from mongodb-kubernetes-operator.

thesayyn avatar thesayyn commented on September 17, 2024

I'd like to implement it. Also, I think that we should accept cmd options instead of env variables. IMHO env variables aren't as easily discoverable as cmd options.
So instead of passing env variables around, we should accept cmd options since we can validate them and they are easy to track.

What do you think?

from mongodb-kubernetes-operator.

chatton avatar chatton commented on September 17, 2024

@thesayyn Using cmd options is definitely one of the extensively used patterns we've seen. I think I prefer using envs while we don't have that many configuration options. Interested to hear from @bznein @antonlisovenko @LouisPlisso on this.

from mongodb-kubernetes-operator.

fabianlindfors avatar fabianlindfors commented on September 17, 2024

@thesayyn @chatton I also prefer environment variables. They are better integrated with Kubernetes in the sense that they can be set from a ConfigMap or Secret.

from mongodb-kubernetes-operator.

theburi avatar theburi commented on September 17, 2024

This issue is labeled as stale because it has been open for more than 30 days with no activity. Remove stale label or comment or this will be closed in a few days.

from mongodb-kubernetes-operator.

alyacb avatar alyacb commented on September 17, 2024

Marking this issue as closed, as this will be supported with the next release.

from mongodb-kubernetes-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.