Install the specified python version found in pyproject.toml about python-poetry-buildpack HOT 4 CLOSED

@paxcodes that’s correct, thank you for the heads up. We have historically committed runtime.txt into our repos, that’s why we are not having this problem.

However, now that we have written a buildpack, we could just export runtime.txt in the buildpack and agree internally, that we are going to specify minors in pyproject.toml.

@marns93 , @mm-matthias what do you think?

from python-poetry-buildpack.

@zyv There are several options:

1. Always write runtime.txt in the buildpack, possibly overwriting an existing runtime.txt. Requires pyproject.toml to contain the minor version number.
2. Always write runtime.txt in the buildpack. Raise an error if there is already an existing runtime.txt. Requires pyproject.toml to contain the minor version number.
3. If there is an existing runtime.txt, do not overwrite it in the generator. Optionally check if the version number in pyproject.toml matches the version in runtime.txt.

For our own purposes I'd go with option 2) as this makes sure the heroku and pyproject.toml versions of python always match.

What are your preferences @paxcodes ?

from python-poetry-buildpack.

from python-poetry-buildpack.

Let's go for raising an exception, otherwise we might end up with discrepancies we'll find out about only too late @mm-matthias & @marns93.

from python-poetry-buildpack.