Git Product home page Git Product logo

Comments (19)

guanlisheng avatar guanlisheng commented on June 24, 2024 1

thank you, @IzzySoft !

from android-money-manager-ex.

IzzySoft avatar IzzySoft commented on June 24, 2024

See: #1425

And: No.

Offending libs:
---------------
* Google Ads (/com/google/ads): Ads,NonFreeComp
* Google Mobile Services (/com/google/android/gms): NonFreeComp
* Firebase (/com/google/firebase): NonFreeNet,NonFreeComp
* Firebase Analytics (/com/google/firebase/analytics): NonFreeComp,Tracking
* Firebase Installations (/com/google/firebase/installations): NonFreeNet

5 offenders.

Doesn't meet the inclusion criteria of my repo either.

from android-money-manager-ex.

vladimir-poleh avatar vladimir-poleh commented on June 24, 2024

Google Ads (/com/google/ads): Ads,NonFreeComp

There is no Google Ads.

from android-money-manager-ex.

guanlisheng avatar guanlisheng commented on June 24, 2024

yup, there is no Google Ads.

seems Firebase is not allowed either.

from android-money-manager-ex.

luisdev avatar luisdev commented on June 24, 2024

What is IzzyOnDroid?

from android-money-manager-ex.

IzzySoft avatar IzzySoft commented on June 24, 2024

@luisdev that's me – and often used as short-hand for my repo (like in this case) or my Android website.

from android-money-manager-ex.

guanlisheng avatar guanlisheng commented on June 24, 2024

See: #1425

And: No.

Offending libs:
---------------
* Google Ads (/com/google/ads): Ads,NonFreeComp
* Google Mobile Services (/com/google/android/gms): NonFreeComp
* Firebase (/com/google/firebase): NonFreeNet,NonFreeComp
* Firebase Analytics (/com/google/firebase/analytics): NonFreeComp,Tracking
* Firebase Installations (/com/google/firebase/installations): NonFreeNet

5 offenders.

Doesn't meet the inclusion criteria of my repo either.

hi @IzzySoft
all 5 offenders have vanished in the master branch would you mind having a check again, thanks

from android-money-manager-ex.

IzzySoft avatar IzzySoft commented on June 24, 2024

Checking the latest release APK:

Offending libs:
---------------
* Google Ads (/com/google/ads): Ads,NonFreeComp
* Google Mobile Services (/com/google/android/gms): NonFreeComp
* Firebase (/com/google/firebase): NonFreeNet,NonFreeComp
* Firebase Analytics (/com/google/firebase/analytics): NonFreeComp,Tracking
* Firebase Installations (/com/google/firebase/installations): NonFreeNet

5 offenders.

Checking the latest pre-release:

Offending libs:
---------------
* Amplitude Android SDK (/com/amplitude): Tracking

1 offenders.

OK, that looks much better. Still, sensitive data and tracking don't go well together. How's Amplitude configured? Is it opt-in? Where's data transmitted to?

from android-money-manager-ex.

guanlisheng avatar guanlisheng commented on June 24, 2024

may I have F-droid's policy overall? then I can self-evaluate first.

from android-money-manager-ex.

IzzySoft avatar IzzySoft commented on June 24, 2024

That's on their website. But the topic of this issue is my repo I guess, where the inclusion criteria are slightly different. If Amplitude is not opt-in, it means the Tracking anti-feature must be applied. If it's opt-in, it won't apply. This rule is for both, F-Droid's and my repo.

from android-money-manager-ex.

guanlisheng avatar guanlisheng commented on June 24, 2024

hi @IzzySoft ,
with #1510, it's opt-in now

would you take a look again at your convenience ?

from android-money-manager-ex.

IzzySoft avatar IzzySoft commented on June 24, 2024

Opt-Out is not Opt-In. I'm no Android dev, but to me the code suggests "enable all Tracking, then check if the user has opted out (and if so disable it again)" (lines 149f in the linked code of MmexApplication.java). Opt-In would be "check if opted in and only if so enable tracking" – i.e. exactly the other way around.

Don't get me wrong, having the chance to opt out is better than not to. But this means before one can opt out, there's already tracking data sent – which is a clear violation of GDPR (you're only permitted to send with the explicit and informed consent of the user).

from android-money-manager-ex.

guanlisheng avatar guanlisheng commented on June 24, 2024

I am not an Android dev either...

the code only enables tracking when the user checks the option in the initial run (sure thing,it would be changed at any time)

Screenshot_20240112_085805

from android-money-manager-ex.

IzzySoft avatar IzzySoft commented on June 24, 2024

Not sure where that screenshot comes from. I've checked the latest release and then even the pre-release. For me, that screen ends with "Default Payee". The "Send anonymous data usage" option is missing. There also was no question for it on the initial run. Yes, after the onboarding the app opened with the settings screen, but as outlined that setting was missing. But the library is there. So are we talking about the same build variant – which results in the APK which is attached to releases?

That said: if it's clearly opt-in and remains a FOSS library (so no proprietary components in), I'd accept AMMX into my repo. I'd need some "metadata" then, like description and screenshots. Ideally in Fastlane structures you maintain, so they are kept up-to-date (my updater would fetch those with each new release then). No need for the Fastlane binaries, I'd just need the text files and the graphics (see my Fastlane Cheat Sheet for guidance). Could that be done?

from android-money-manager-ex.

guanlisheng avatar guanlisheng commented on June 24, 2024

https://github.com/moneymanagerex/android-money-manager-ex/releases/tag/2024.01.12.1012 has the screenshot.

still studying the details how to prepare for F-Droid...

from android-money-manager-ex.

IzzySoft avatar IzzySoft commented on June 24, 2024

Confirmed with that release, thanks!

still studying the details how to prepare for F-Droid...

May I suggest you start with setting up Fastlane structures (for description and screenshots; no need to install its binaries, just the metadata suffice)? You can use my Fastlane Cheat Sheet for guidance there. Once set up, just give me a ping and I can immediately include it with my repo.

Apart from that: Quick path to get your app into F-Droid is easier to understand than the "official documentation" 😉

from android-money-manager-ex.

guanlisheng avatar guanlisheng commented on June 24, 2024

many thanks.

I just found https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/com.money.manager.ex.yml,
it seems major document preparation is in place, but one critical piece is still #1425, is that correct?

btw, where can i find the build/verify result from f-droid?

from android-money-manager-ex.

IzzySoft avatar IzzySoft commented on June 24, 2024

btw, where can i find the build/verify result from f-droid?

https://monitor.f-droid.org/builds/log/com.money.manager.ex/1013

(so for future builds, you just need to substitute the versionCode at the end of that URL). Taken from the current build cycle's monitor.

from android-money-manager-ex.

wolfsolver avatar wolfsolver commented on June 24, 2024

Finally available on fdroid
https://f-droid.org/packages/com.money.manager.ex/

from android-money-manager-ex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.