Comments (15)
This slipped away due to all the other bits, but I'd like to revisit it.
The recommendations above all still stand, except I'm leaning more towards a dash instead of an underscore, to follow git
convention. Thus the following changes would occur:
bitmonerod
->monero-daemon
(ormonero-node
?)simplewallet
->monero-wallet-cli
blockchain_dump
->monero-blockchain-dump
blockchain_import
->monero-blockchain-import
blockchain_export
->monero-blockchain-export
- utility bits (eg. pop-blocks) from blockchain_import ->
monero-utils-blockchain
cn_deserialize
-> dropped, or renamed tomonero-utils-deserialize
blockchain_converter
-> dropped, no longer necessarysimpleminer
-> dropped due to disuse
And later on:
monero-wallet-rpc
once we've pulled through the old rpcwallet workmonero-deprecated-rpc
for the RPC stub for daemon RPC calls, once the 0MQ work is done
Suggestions welcome.
from monero.
Naming of resulting binaries with '-' is ok. Naming of individual source files should use underscores. Debuggers don't like filenames/symbols with dashes in them.
from monero.
I'd also like to change the CRYPTONOTE_NAME to monero. The knock-on effect is it will change the bitmonero bit in the data directory (which was formerly ~/.bitmonero / AppData\Roaming\bitmonero).
I'm of the opinion that the best to deal with this is to add a small stub of code to the daemon that will rename an "old" data directory it encounters to the new one. This check should be hard-coded (ie. don't introduce extra unnecessary constants like OLD_CRYPTONOTE_NAME).
As an aside: transitionary stubs such as this one should always be introduced with a deprecation date. For this change, I suggest 12 months, after which this code is completely removed. If anyone runs into a problem thereafter, they can always grab an older tagged release before switching up to a new one (or in this case just rename the folder). It's not feasible to have Monero littered with code to ensure compatibility with ancient and deprecated versions.
from monero.
May I propose to change the exe file names like the following:
- bitmonerod.exe -> monero_daemon.exe
- simplewallet.exe -> monero_wallet_simple.exe
- rpcwallet.exe -> monero_wallet_rpc.exe
Just for consistency :)
from monero.
Marked for inclusion in the next tagged release
from monero.
How about s/monero-blockchain/monero-utils/ ?
Or s/monero-blockchain/monero-utils-blockchain/ too.
from monero.
Please accept vote for: monerod
-- it is short and follows the convention.
I would combine all those separate blockchain manipulation binaries into either one binary with subcommands (monero-blockchain import|export|dump|convert
) or even roll it into monerod (after all, the daemon "owns" the blockchain). Not sure what cm_serialize does, but hopefully it can also be rolled into. With all respect to unix principle, I think grouping these is better for the end user than having them as separate binaries.
One vote for monero-wallet
instead of monero-wallet-cli
for sake of shortness, although I don't know what the *-rpc binaries are intended to be and how they relate to *-cli?
from monero.
Yes, I had proposed rolling import/export into the daemon earlier as well. It would have made the migration code much easier to write.
from monero.
@radfish it's silly to have monero-wallet offer both CLI and RPC modes, since they're super distinct and will need to be able to be developed independently of each other without affecting each other's moving parts. so having one that is CLI, and pulling out the RPC stuff into its own binary (as we did with rpcwallet on the now-defunct development branch) is the way to allow that to happen.
from monero.
Mostly closed by #1039, will have to consider the CRYPTONOTE_NAME stuff later on.
from monero.
It looks like Travis-CI is broken -- possibly related to the rename?
https://travis-ci.org/monero-project/bitmonero
from monero.
@jetwhiz the Travis stuff moved as well, check https://travis-ci.org/monero-project/monero
from monero.
@fluffypony -- I think the README.md is still pointing to https://travis-ci.org/monero-project/bitmonero
from monero.
@jetwhiz tks - busy fixing that now :)
from monero.
Blockchain is still being written to legacy folder name C:\ProgramData\bitmonero\lmdb as of version 0.12.2.0
from monero.
Related Issues (20)
- Monero RPC Wallet loosing connection to the daemon HOT 4
- master branch does not contain newer checkpoints HOT 1
- Funds are blocked every time I send them with RPC Wallet HOT 1
- tx_memory_pool is now private in master. HOT 2
- Suggestion: When there is a backlog at the current fee level, print a menu showing backlogs and costs at each fee level HOT 4
- monerod memory usage on busy public node HOT 2
- MacOS/MoneroGui: button to do first-run install HOT 9
- [Discussion] Blockers towards including Rust into monero codebase HOT 4
- Support getting unconfirmed transfers from monero-wallet-rpc without fetching from pool
- Support updating the pool state in monero-wallet-rpc `refresh`
- Immediate Crash on Launch with Qt Quick Errors and OpenGL Context Failure in monero-wallet-gui HOT 1
- Hide the sending address and prompt that destinations do not exist HOT 4
- Build failure with Boost 1.85.0 HOT 4
- The Monero core software wallet API will (probably) switch from 'wallet2.h' to 'wallet2_api.h'
- Remove refresh from call from import_multisig HOT 3
- Daemon recurring error message HOT 8
- Daemon crashed last night with only a warning HOT 18
- A lot of 150/2 transactions in the txpool causes memory spike / OOM HOT 23
- aggregating multisig partial signatures HOT 2
- Cannot connect wallet client to daemon HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from monero.