help: cancellable rpc about sanic-jsonrpc HOT 3 OPEN

Hi, it's nice to see someone is interested in my project. I got your point. I think canceling a Request with another request is a great idea!

1. I've checked your example and I confirm args are doubled. I need some time to debug what's going on.
2. Sounds like a feature request! I can add a decorator like Sanic's exception. That way you can intercept a CancelledError and wrap it as a jsonrpc.Error

Also, with the upcoming listeners feature I see how CancellableSanicJsonrpc may bee implemented more easily. I'll add an example.

Stay tuned. Thank you!

from sanic-jsonrpc.

Hi @hyansuper!

I fixed the args doubling in master. It happened because Router tries to validate call to new_coro(*args, **kwargs), not print_task(count: int) -> str. I fixed the varargs behaviour, but to make Router validate real call you must use @wraps(coro) decorator on new_coro(*args, **kwargs).

You can try it now by installing git version pip install git+https://github.com/mon4ter/sanic-jsonrpc -U. If it works for you you can ask me to release a hotfix, but I think it's better to wait until the 0.3.0 release with listener and exception decorators.

Stay tuned. Thank you!

from sanic-jsonrpc.

do you mean this? now the last element of args is missing

from sanic-jsonrpc.