Git Product home page Git Product logo

Comments (1)

gilmoreorless avatar gilmoreorless commented on September 27, 2024

First up, please don't list "latest" in the version field, as it becomes incorrect very quickly. For example, a new version has already been published today. To diagnose issues, we need exact version numbers.

From looking at the code, it seems moment().tz('') is treated exactly the same as moment().tz(), returning string | undefined. This is because of a check of if (zone) which treats the empty string the same as undefined.

I agree that this behaviour doesn't match the type definitions, and isn't quite correct. But fixing it would technically be a breaking change, as code that worked previously could start throwing errors. I'm going to link this to the proposed breaking changes in #1039.

from moment-timezone.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.