Remove conversion to meters for diagnostics in non-Boussinesq mode about mom6 HOT 7 CLOSED

GV%H_to_mks already fulfills the role of the proposed GV%H_to_native_h, in that it resolves to either GV%H_to_m or GV%H_to_kg_m2 depending on whether the model is in Boussinesq or non-Boussinesq mode.

from mom6.

Ah ok, thanks @Hallberg-NOAA for clarifying. Life is a bit easier then so that all that really needs to be done is to replace those diagnostics with GV%H_to_mks

from mom6.

We discussed this at the MOM6 dev call on 4/25/2022, and everyone is on board with making the units of most of these thickness variables on the second list dependent on whether the Boussinesq approximation is made. The one exception is thkcello, which is always defined to be thicknesses in m, as opposed to masscello, which is always in kg m-2.

from mom6.

@klindsay28 and @ashao, are either of you aware of efforts that are underway to implement your excellent suggestion, or do we need to arrange for someone to look into this?

from mom6.

I'm not aware of an effort to implement this.

from mom6.

This issue should be fully addressed once NOAA-GFDL#181 has been merged into the main branch of the code. @ashao or @klindsay28, if you would like to provide review comments on that PR, it would be greatly appreciated.

from mom6.

The code correcting this issue has now been merged onto the main branch of MOM6 as a part of #1582, with the specific changes coming in from NOAA-GFDL#181.

from mom6.