Git Product home page Git Product logo

Comments (4)

molnarg avatar molnarg commented on June 25, 2024

I've solved this with a better heuristic algorithm for chunking that tries to achieve equally sized chunks that are smaller than the initial window size (and MAX_HTTP_PAYLOAD_SIZE), but probably needs more work in the future.

from node-http2.

tatsuhiro-t avatar tatsuhiro-t commented on June 25, 2024

So if there is 99 bytes window left, then dead lock still occurs. Why do
you just cut the first min(remaining_window, MAX_HTTP_PAYLOAD_SIZE,
buffer.size) bytes of buffer and send it?

from node-http2.

molnarg avatar molnarg commented on June 25, 2024

Sounds good, but I feel like deadlocks will be possible even then... The best thing would be maybe to postpone chunking until before sending out the next chunk (lazy chunking). The next chunk size would be determined by the function you mentioned, and then next chunk size with the same function etc. And when window runs out, stop until there's window available again.

from node-http2.

molnarg avatar molnarg commented on June 25, 2024

Solved in bd7886b.

from node-http2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.