Comments (4)
I've solved this with a better heuristic algorithm for chunking that tries to achieve equally sized chunks that are smaller than the initial window size (and MAX_HTTP_PAYLOAD_SIZE), but probably needs more work in the future.
from node-http2.
So if there is 99 bytes window left, then dead lock still occurs. Why do
you just cut the first min(remaining_window, MAX_HTTP_PAYLOAD_SIZE,
buffer.size) bytes of buffer and send it?
from node-http2.
Sounds good, but I feel like deadlocks will be possible even then... The best thing would be maybe to postpone chunking until before sending out the next chunk (lazy chunking). The next chunk size would be determined by the function you mentioned, and then next chunk size with the same function etc. And when window runs out, stop until there's window available again.
from node-http2.
Solved in bd7886b.
from node-http2.
Related Issues (20)
- Some tests failing under node 6.9.4
- Tests fail when node version >= 6.3.0
- HTTP Proxy how? HOT 3
- Question. About "padding" of framer.js
- SETTINGS frame in framer.js
- Binary output when talking to Twitter API HOT 1
- How to set request setTimeout? HOT 1
- Error: stream.push() after EOF HOT 1
- Avoid the Assertion error? HOT 2
- Please commit doc
- newSession / resumeSession events aren't fired HOT 1
- AssertionError: false == true
- Project dead? HOT 2
- How send json?
- node-http2 v4 via fork ? HOT 4
- throw er; // Unhandled 'error' event HOT 3
- Moving away from the Buffer constructor HOT 1
- Error: Sending illegal frame (HEADERS) in CLOSED state. HOT 1
- Response issue HOT 1
- Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-http2.