buffer breaks in IE11 about iso3166-1 HOT 11 CLOSED

@pcaleja hi phillip :) taking a look now.

from iso3166-1.

@michael-hertzberg-zocdoc

Thanks! :)

from iso3166-1.

@pcaleja could you try pulling down version v0.2.6 and see if that fixes the problem?

from iso3166-1.

@michael-hertzberg-zocdoc getting this error when I build, could be cause of my build task though.

Error: Cannot find module './zlib' from '/Users/philip/Documents/Websites/sk-marketing/node_modules/iso3166-1/lib'

from iso3166-1.

@pcaleja eep! pull 0.2.7 :)...

from iso3166-1.

@michael-hertzberg-zocdoc

It still persists. I noticed buffer updated this function. Not sure if it will help though.

function fromString(string, encoding) {
  if (typeof encoding !== 'string' || encoding === '')
    encoding = 'utf8';

  if (!Buffer.isEncoding(encoding))
    throw new TypeError('"encoding" must be a valid string encoding');

  var length = byteLength(string, encoding);

  if (length === 0)
    return Buffer.alloc(0);

  if (length >= (Buffer.poolSize >>> 1))
    return binding.createFromString(string, encoding);

  if (length > (poolSize - poolOffset))
    createPool();
  var actual = allocPool.write(string, poolOffset, encoding);
  var b = allocPool.slice(poolOffset, poolOffset + actual);
  poolOffset += actual;
  alignPool();
  return b;
}

Also it seems like zlib-browserify is now being searched outside of the module's node_module directory.

Error: Cannot find module 'zlib-browserify' from '/Users/philip/Documents/Websites/sk-marketing/node_modules/iso3166-1/src'

from iso3166-1.

@pcaleja lets try again >.< -- v0.2.8

after that, then i'll need to get back to you :(...

from iso3166-1.

@moimikey

Still persists :(.. It's not urgent since, I'll disable this for now in IE but it would be great to have a fix. Let me know if it's something on my side as well. Thanks again!

from iso3166-1.

i still want to revisit this... ie11 hell.

from iso3166-1.

@moimikey last time I looked at it, the issue seems to be coming from buffer and I think node's newer version should fix these issues but I'm not 100% sure.

from iso3166-1.

fixed in latest version

from iso3166-1.