Comments (5)
Locally I can hack the configs to pass the devServer
from Storybook to new DevServer()
in startDevServer.js
, and it will allow for refreshing the page, but only up until some React error that that causes crashes the page. 🤔
from web.
IIRC it required more logic and integration code for the Storybook, so I made a separate task in the future and focused on basic functionality. It's still planned.
Meanwhile I'm curious what exactly you expect to work?
Some sort of HMR? Or just page refresh?
from web.
The baseline would be auto page refresh much like WDS does in other cases with
webSockets.sendImport('data:text/javascript,window.location.reload()');
I'm not one for a lot of ceremony on this, but being we've received it in so many other contexts, it's hard to get away from this sort of a feature when suggesting tools like this to a team.
It would be interesting to see actual HMR included...but, I've never seen it really work, so it wouldn't be me pushing for it by any means. I'm not even sure if the HMR tools that OpenWC was working with ever actually got updated to [email protected]
let alone the upcoming [email protected]
release.
Practically, the vite
builder accepts the Storybook devServer
into its config, so there is likely a path to make the baseline of what I was trying work, I just don't know how to debug the issue that it causes in Storybook's React UI. 😞
from web.
@Westbrook thanks for your feedback. I agree we need to implement the baseline, I think the previous storybook-prebuilt setup had smth like that, and also not a real HMR. I hope to pick this up soon.
from web.
This seems like the laziest possible path: #2482
from web.
Related Issues (20)
- browser not launching in Windows in GitHub Actions
- updatedSession.browser.startSession is not a function
- `TypeError: Failed to fetch dynamically imported module` only in Windows in GitHub Actions HOT 1
- Storybook Builder: Failed to fetch dynamically imported module: http://localhost:6006/stories/Configure.mdx HOT 3
- bumping @web/dev-server-esbuild to 1.0.0 leads to "SyntaxError: Invalid or unexpected token" HOT 10
- Support for HTTPS HOT 14
- TypeError: Failed to resolve module specifier "@esm-bundle/chai" HOT 8
- How to handle mixed content errors on playwright HOT 6
- [@web/dev-server-import-maps] Support for external import maps HOT 5
- [rollup-plugin-import-meta-assets]: The output result was wrapped twice with `new URL()` HOT 8
- A modern alternative to the `--node-resolve` flag HOT 5
- Web dev Server does not work with following import
- Storybook Builder: Globals from Storybook Missing HOT 3
- Change name of 'assets' folder
- [@web/test-runner-commands] Support prefers-reduced-transparency and prefers-contrast in emulateMedia
- [WTR/Playwright] "Error: page.goto:" messages void passed tests in Firefox
- ZION GENERALS
- `testsFinishTimeout` does not print browser logs
- Concurrent tests don't call `requestAnimationFrame` consistently with Puppeteer HOT 2
- browserContext.newPage: Target closed (failed on Webkit) on macOS with M1 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from web.