Git Product home page Git Product logo

Comments (5)

Westbrook avatar Westbrook commented on September 27, 2024

Locally I can hack the configs to pass the devServer from Storybook to new DevServer() in startDevServer.js, and it will allow for refreshing the page, but only up until some React error that that causes crashes the page. 🤔

from web.

bashmish avatar bashmish commented on September 27, 2024

IIRC it required more logic and integration code for the Storybook, so I made a separate task in the future and focused on basic functionality. It's still planned.

Meanwhile I'm curious what exactly you expect to work?
Some sort of HMR? Or just page refresh?

from web.

Westbrook avatar Westbrook commented on September 27, 2024

The baseline would be auto page refresh much like WDS does in other cases with

webSockets.sendImport('data:text/javascript,window.location.reload()');

I'm not one for a lot of ceremony on this, but being we've received it in so many other contexts, it's hard to get away from this sort of a feature when suggesting tools like this to a team.

It would be interesting to see actual HMR included...but, I've never seen it really work, so it wouldn't be me pushing for it by any means. I'm not even sure if the HMR tools that OpenWC was working with ever actually got updated to [email protected] let alone the upcoming [email protected] release.

Practically, the vite builder accepts the Storybook devServer into its config, so there is likely a path to make the baseline of what I was trying work, I just don't know how to debug the issue that it causes in Storybook's React UI. 😞

from web.

bashmish avatar bashmish commented on September 27, 2024

@Westbrook thanks for your feedback. I agree we need to implement the baseline, I think the previous storybook-prebuilt setup had smth like that, and also not a real HMR. I hope to pick this up soon.

from web.

Westbrook avatar Westbrook commented on September 27, 2024

This seems like the laziest possible path: #2482

from web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.