rollup-plugin-workbox importing wrong rollup-plugin-terser package about web HOT 9 CLOSED

We have some issues with the CI that we're still investigating. As a temporary workaround you can use a lower version of the plugin.

from web.

@koddsson could you take a look? Maybe this has impacted some of the other changes as well?

from web.

Same issue for dev-server-storybook https://github.com/modernweb-dev/web/blob/master/packages/dev-server-storybook/src/build/rollup/createRollupConfig.ts#L8

from web.

Raised a PR for the issue: #2265

from web.

@koddsson could you take a look? Maybe this has impacted some of the other changes as well?

Weird! I thought I had grepped the whole code-base for this, but evidently not. Odd that no build or test failed with this. I'll try to get the PR merged.

from web.

Odd that no build or test failed with this. I'll try to get the PR merged.

It might accidentally work, if some other packages/dependencies are still using the old terser-plugin package as a sub-dependency. As long as it ends up in node_modules, it will be resolved and not raise an error - even, if it is not listed in your package.json anymore.

from web.

Hi.
I have the same issue with the @web/dev-server-storybook plugin.

> build-storybook --output-dir demo-storybook

node:internal/modules/cjs/loader:1029
  throw err;
  ^

Error: Cannot find module 'rollup-plugin-terser'
Require stack:
- /Users/.../node_modules/@web/dev-server-storybook/dist/build/rollup/createRollupConfig.js
- /Users/.../node_modules/@web/dev-server-storybook/dist/build/build.js
- /Users/.../node_modules/@web/dev-server-storybook/dist/build/cli.js

Could it be fixed by merging this PR #2265 ?

from web.

should be fixed in #2265

from web.

It looks like this was fixed as part of major version bump v8. Is it possible to get this patched for version 7 as well? I'm seeing this error after this fix in @open-wc/building-rollup, because it is still using rollup-plugin-workbox v7 but has removed rollup-plugin-terser as a dependency (exactly the situation mentioned above).

I started a PR to update to rollup-plugin-workbox v8, but there are a lot of changes as a result of moving to workbox 7 that I don't have the context for. But if that's preferred, I can continue with trying to put up a PR for that in @open-wc/building-rollup.

from web.