Git Product home page Git Product logo

Comments (25)

Harao90 avatar Harao90 commented on August 22, 2024 1

image

it works if everything is local,

Lobe Theme, former kitchen theme.
https://github.com/canisminor1990/sd-webui-lobe-theme/releases

from sd-webui-comfyui.

rookiexjl avatar rookiexjl commented on August 22, 2024 1

--comfyui-listen --webui-comfyui-client-address 192.168.xx,xx add is ok

from sd-webui-comfyui.

ljleb avatar ljleb commented on August 22, 2024

Are you trying to run both the webui and comfyui on the same machine, or you are trying to start comfyui on a different machine from the webui?

At the moment, it is not possible to separate them. We are considering making this possible, although it is not a priority ATM.

If you simply need the webui to try to connect to a different url for some reason, then you can change the "Address of the ComfyUI server as seen from the webui" in the settings of the extension.

from sd-webui-comfyui.

ljleb avatar ljleb commented on August 22, 2024

Note that you have to wait for the comfyui server to finish loading before opening a web browser at the webui URL ATM for it to work. Keep an eye on #77 for the resolution of that issue.

from sd-webui-comfyui.

Harao90 avatar Harao90 commented on August 22, 2024

Are you trying to run both the webui and comfyui on the same machine, or you are trying to start comfyui on a different machine from the webui?

At the moment, it is not possible to separate them. We are considering making this possible, although it is not a priority ATM.

If you simply need the webui to try to connect to a different url for some reason, then you can change the "Address of the ComfyUI server as seen from the webui" in the settings of the extension.

You mean this right?
image

I thought that was it too,
Didn't work, tries to connect to the local host as in the first post.

They are running on the same machine, I have a web server doing reverse proxy to stable diffusion so i can access it via a domain sd.mydomain.com, and it works. I have done the same thing for the confyui too. confy.mydomain.com and it works directly too. I wanted to make the tab on stable diffusion access but it always tries to connect to the local host. i have tried with private IPs too.

from sd-webui-comfyui.

ljleb avatar ljleb commented on August 22, 2024

I see. Can you share your logs? Is there a message that looks like "[ComfyUI extension] changing the ComfyUI client address from {client_url} to {loopback_address}"?

from sd-webui-comfyui.

Harao90 avatar Harao90 commented on August 22, 2024

Found this

image

i am trying to use --webui-comfyui-client-address

, adding "--client-address confy.domain.com" to the Additional cli arguments on stable diffusion webui, but it says the argument is not right, but i think it is on the right path.

from sd-webui-comfyui.

ljleb avatar ljleb commented on August 22, 2024

The argument has to be --webui-comfyui-client-address confy.domain.com, not just "--client-address". However it's odd that the settings are ignored. Are you sure they have been saved, and then you reloaded the ui or the server completely? The settings should take priority over the cli arguments.

from sd-webui-comfyui.

Harao90 avatar Harao90 commented on August 22, 2024

got some progress

image

Not working yet, but it is starting to appear something is changing, i tried with the domain and it puts the http and port automatically so i thought it was because of that. Change it to just the ip, and the same result, all white.

ill try some more things and give feedback.

if you think of something please say, for now ill continue using it as i had before and tackle this later, it was just to have everything in one place.

Thanks for the help!

from sd-webui-comfyui.

ljleb avatar ljleb commented on August 22, 2024

Wait, which webui host is this? It does not look like a1111 or vlad. We can't support all possible webui hosts implementation, it just wouldn't be practical to aim for this... Does the extension work for your use case in a1111 or vlad, or it also fails there?

from sd-webui-comfyui.

ljleb avatar ljleb commented on August 22, 2024

Do I understand that the issue is resolved then? Or your earlier setup is also a local installation that did not work for some reason

from sd-webui-comfyui.

Harao90 avatar Harao90 commented on August 22, 2024

Do I understand that the issue is resolved then? Or your earlier setup is also a local installation that did not work for some reason

It is not resolved, I put everything to default and used the local machine to show it works as intended.

When I access from my domain, everything is default, it can't connect to confyUI because it tries to access 127.0.0.1 and fails, as it should. When I use the --webui-comfyui-client-address confy.domain.com or --webui-comfyui-client-address 192.168.x.x it gives no error just white.

When I have time ill try a new a1111 installation just with the extension to try to isolate the issue.

from sd-webui-comfyui.

ljleb avatar ljleb commented on August 22, 2024

Ah wait, now I understand your setup. I don't have a domain name to test with, so it's hard for me to debug this. I'm not sure why the ui is all white like that. In the end, the comfyui tab we added is really just an iframe trying to load the content from a specified address. The tab shouldn't do anything special on the ui side.

Maybe it's stuck for some reason during loading? I'm not quite sure. Could you share the entire logs? It may show whether comfyui is starting or not. Maybe I could spot a clue in there.

from sd-webui-comfyui.

E2GO avatar E2GO commented on August 22, 2024

Same issue.

from sd-webui-comfyui.

ljleb avatar ljleb commented on August 22, 2024

For reverse proxy users, IIUC the problem is that reverse proxy needs to be implemented for comfyui in addition to the existing reverse proxy for the webui.

We were considering adding a local tunnel implementation but it turned out to be a lot of work. we may add it some time in the future. PRs are welcome for this use case. We are currently focusing on more urgent matters, but may come back to this at some point.

from sd-webui-comfyui.

ljleb avatar ljleb commented on August 22, 2024

related: #9

from sd-webui-comfyui.

ljleb avatar ljleb commented on August 22, 2024

#91 should have fixed the url setting not being taken into account. @Harao90 let us know if the issue is fixed on your end with this option.

from sd-webui-comfyui.

ljleb avatar ljleb commented on August 22, 2024

A solution for reverse proxy to work without setting up separate proxies for the webui and comfyui would be to setup a specific route in a1111, for example http://localhost:7860/sd-webui-comfyui/comfyui, as a reverse proxy to http://localhost:8189 (actual comfyui server). Then we can point the iframes to the new url and stop worrying about CORS and whatnot

from sd-webui-comfyui.

vivagonna avatar vivagonna commented on August 22, 2024

--comfyui-listen --webui-comfyui-client-address 192.168.xx,xx add is ok

Seems not work

pre_main.py: error: unrecognized arguments: --webui-comfyui-client-address 0.0.0.0

from sd-webui-comfyui.

rookiexjl avatar rookiexjl commented on August 22, 2024

from sd-webui-comfyui.

rookiexjl avatar rookiexjl commented on August 22, 2024

from sd-webui-comfyui.

ljleb avatar ljleb commented on August 22, 2024

The extension should work for reverse proxy users now. #107 (comment)

from sd-webui-comfyui.

rookiexjl avatar rookiexjl commented on August 22, 2024

1692237976438
1692063463456
1692237858214

from sd-webui-comfyui.

ljleb avatar ljleb commented on August 22, 2024

Is there a line [sd-webui-comfyui] Created a reverse proxy route to ComfyUI: /sd-webui-comfyui/comfyui in the logs? If not, your setup does not seem to require a reverse proxy to work. This is different from other people using runpod.io for example.

from sd-webui-comfyui.

rookiexjl avatar rookiexjl commented on August 22, 2024

[ComfyUI] Device: cuda:0 NVIDIA GeForce RTX 3070 Laptop GPU : native
[ComfyUI] Using xformers cross attention
[ComfyUI] [sd-webui-comfyui] Launching ComfyUI with arguments: --listen 0.0.0.0 --port 8189
[ComfyUI]
Other computers can use ComfyUI 192.168.xx.xx:7860

from sd-webui-comfyui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.