Comments (5)
What is the use for this? I worry that testing two PRs at the same time with a fixed network might cause a port conflict.
from datakit.
Well DataKitCI aims to be a generic CI solution right? I would like to use it for my CI scenario, where I have two containers, one with the service I am testing and the other one with my acceptance tests. For the latter to be able to access the service, I need to use Docker run's --network
parameter.
It would also be nice to specify other parameters for Docker run, including port mappings. I've seen mirageCI's Docker utility has some more configuration options (e.g. volumes, tags), but I would prefer not to reimplement a utility like this when DataKitCI has it already.
Yeah I can see that if the CI runs the tests for PRs parallelly, then this can cause problems if the container exposes any ports (which is not the case for my tests). What do you suggest? Would it be possible to parameterize Docker.run's separately for PRs?
from datakit.
How do the acceptance tests access the service, if it doesn't expose any ports? Is there a fixed test container, or a new one for each PR?
from datakit.
Sorry I was not clear enough. The service container does expose ports, but for now, it is not started by the CI. The test container is built and run for each commit/PR.
More generally, I think it would be nice if DataKitCI could support more complex build/test scenarios involving multiple containers communicating with each other.
from datakit.
Yes. It probably needs docker-compose support, really.
from datakit.
Related Issues (20)
- Invalid use of `${ROOT}` HOT 2
- check version
- Datakit using irmin store not writing to repository HOT 1
- Minor release with s/per_file/per_module/ ? HOT 3
- "git commit" seems to break the transaction interface HOT 4
- Unable to run CI example (permission denied) HOT 7
- Unable to run DataKit Local-Git bridge HOT 2
- Unix.ENAMETOOLONG when using datakit-bridge-local-git HOT 3
- Unix.EROFS while running self-ci locally HOT 8
- CI: Rebuilding a job doesn't cancel its childen jobs HOT 5
- Can't create new live log on branch HOT 13
- Assert_failure ci/src/cI_monitored_pool.ml:44:2 HOT 5
- CI: local-bridge does not rebuild on new commit HOT 3
- CI: local state repo HOT 2
- CI: unable to use Git.run HOT 2
- Datakit-CI is rebuilding PR on title edit HOT 3
- Irmin.merge_head: conflict, retrying (223684) (100% CPU) HOT 10
- Irmin 2.0.0
- datakit-client is not compatible with result 1.5 on OCaml 4.08+
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from datakit.